Skip to content

Report that an action has been aborted on configuration failures - #81

Merged
alexkappa merged 7 commits into
mainfrom
report-action-aborted
Jun 24, 2020
Merged

Report that an action has been aborted on configuration failures#81
alexkappa merged 7 commits into
mainfrom
report-action-aborted

Conversation

@alexkappa

@alexkappaalexkappa commented Jun 23, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds support for reporting with status: aborted if a configuration failure has occurred.

Dependencies

We shouldn't merge this PR until the /repositories/{repository_id}/code-scanning/analysis/statusschema has been updated to allow for the new status.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@alexkappa
alexkappa marked this pull request as ready for review June 24, 2020 11:58
robertbrignull
robertbrignull reviewed Jun 24, 2020
View reviewed changes

@robertbrignullrobertbrignull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo that needs fixing, but otherwise looks basically there.

Could you run a test? Just push a new branch where you've intentionally made the config invalid and make sure it's behaving as expected.

Comment threadsrc/util.ts Outdated
Comment threadsrc/setup-tracer.ts Outdated
robertbrignull
robertbrignull approved these changes Jun 24, 2020
View reviewed changes

@robertbrignullrobertbrignull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexkappa
alexkappa merged commit 6846c70 into mainJun 24, 2020
@alexkappa
alexkappa deleted the report-action-aborted branch June 24, 2020 13:06
@github-actionsgithub-actionsBot mentioned this pull request Jun 29, 2020
Merged
@snyk-botsnyk-bot mentioned this pull request Apr 24, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertbrignullrobertbrignullrobertbrignull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexkappa@robertbrignull