Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Add support for build tracing - #178

Closed
sauyon wants to merge 8 commits into
github:mainfrom
sauyon:tracing-1
Closed

Add support for build tracing#178
sauyon wants to merge 8 commits into
github:mainfrom
sauyon:tracing-1

Conversation

@sauyon

@sauyonsauyon commented Jun 12, 2020

Copy link
Copy Markdown
Contributor

c.f. #170

sauyon
sauyon commented Jun 12, 2020
View reviewed changes
Comment threadextractor/cli/go-extractor/go-extractor.go
i++
}
case "-i":
case "-p", "-asmflags", "-buildmode", "-compiler", "-gccgoflags", "-gcflags", "-installsuffix",

@sauyonsauyonJun 12, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you come up with this list, and how do we maintain it going forward?

I used the documentation from go help build. Unfortunately I think we'll have to maintain it manually as there are new releases.

Comment threadextractor/cli/go-extractor/go-extractor.go Outdated
Comment threadextractor/cli/go-extractor/go-extractor.go
if i+1 < len(args) {
i++
}
case "-i":

@sauyonsauyonJun 12, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like -i isn't actually skipped?

It is, as it's not added to the build flags list. I could put a continue here to make it more clear, though?

Comment threadextractor/cli/go-extractor/go-extractor.go Outdated
@sauyon
sauyonforce-pushed the tracing-1 branch 2 times, most recently from 4d79db5 to e454bc8CompareJune 12, 2020 17:57
@sauyon

sauyon commented Jun 22, 2020

Copy link
Copy Markdown
ContributorAuthor

The fix for the MacOS issues has been merged; should I started testing on OS X again?

@max-schaefer

max-schaefer commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

Yes, please. I've not yet been able to find time to look at this again, I'm afraid.

@max-schaefer
max-schaefer changed the base branch from master to mainAugust 10, 2020 15:58
@max-schaefer

max-schaefer commented Sep 7, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

I take it this is superseded by #324?

@sauyon

sauyon commented Sep 7, 2020

Copy link
Copy Markdown
ContributorAuthor

Ah, right.

@sauyonsauyon closed this Sep 7, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sauyon@max-schaefer