Uh oh!
There was an error while loading. Please reload this page.
Go: make ParameterNodes for unused parameters #2 (make a disjoint class for unused ones) - #13672
Merged
owen-mc merged 3 commits intoJul 12, 2023
Conversation
ParameterNodes for unused parameters using a disjoint classParameterNodes for unused parameters #2 (make a disjoint class for unused ones)owen-mc
marked this pull request as ready for review
July 12, 2023 13:40
smowton
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was confusing that no
ParameterNodewas created if a parameter wasn't used. This was becauseParameterNodes are linked toSsaNodes. We solve this by making a new kind ofParameterNodefor unused parameters.An alternative approach to #13664