Uh oh!
There was an error while loading. Please reload this page.
Dataflow: Move the shared library to a properly shared qlpack. - #13863
Merged
Conversation
aschackmullforce-pushed
the
dataflow/pack4
branch
from
August 1, 2023 11:54
6ce4cbf to
3904be2Compare
Comment on lines
+57
to
+63
| /** | ||
| * The cost limits for the `AccessPathFront` to `AccessPathApprox` expansion. | ||
| * | ||
| * `apLimit` bounds the acceptable fan-out, and `tupleLimit` bounds the | ||
| * estimated per-`AccessPathFront` tuple cost. Access paths exceeding both of | ||
| * these limits are represented with lower precision during pruning. | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style.
Comment on lines
+69
to
+75
| /** | ||
| * The cost limits for the `AccessPathApprox` to `AccessPath` expansion. | ||
| * | ||
| * `apLimit` bounds the acceptable fan-out, and `tupleLimit` bounds the | ||
| * estimated per-`AccessPathApprox` tuple cost. Access paths exceeding both of | ||
| * these limits are represented with lower precision. | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style.
| * Constructs a global data flow computation. | ||
| */ | ||
| module Global<ConfigSig Config> implements GlobalFlowSig { | ||
| private module C implements FullStateConfigSig { |
Check warning
Code scanning / CodeQL
Data flow configuration module naming
| * Constructs a global data flow computation using flow state. | ||
| */ | ||
| module GlobalWithState<StateConfigSig Config> implements GlobalFlowSig { | ||
| private module C implements FullStateConfigSig { |
Check warning
Code scanning / CodeQL
Data flow configuration module naming
aschackmullforce-pushed
the
dataflow/pack4
branch
from
August 1, 2023 12:02
3904be2 to
199d143Comparegeoffw0
reviewed
Aug 1, 2023
geoffw0
left a comment
Contributor
There was a problem hiding this comment.
Swift changes LGTM.
I'd like to see DCA runs on this pull request.
aschackmull
commented
Aug 1, 2023
ContributorAuthor
I'll start those shortly - I just wanted to clear out the worst compilation errors with some quick CI first. |
aschackmull
commented
Aug 2, 2023
ContributorAuthor
Dca looks uneventful. |
atorralba
approved these changes
Aug 2, 2023
aschackmull
commented
Aug 2, 2023
ContributorAuthor
I don't 😄 |
geoffw0
approved these changes
Aug 2, 2023
michaelnebel
approved these changes
Aug 2, 2023
michaelnebel
left a comment
Contributor
There was a problem hiding this comment.
Looks plausible to me! 👍
Thank you Anders!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This makes the data flow library into a proper qlpack!
Several small tweaks were needed for the individual languages to ensure that the predicate types matched the signature.