Skip to content

Data flow: Refactor shared library - #13901

Merged
hvitved merged 11 commits into
github:mainfrom
hvitved:dataflow/refactor
Aug 7, 2023
Merged

Data flow: Refactor shared library#13901
hvitved merged 11 commits into
github:mainfrom
hvitved:dataflow/refactor

Conversation

@hvitved

@hvitvedhvitved commented Aug 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Move DataFlowImpl(Common).qll into an internal folder.
  • Rename DataFlowParameter to InputSig and move it into DataFlow.qll.
  • Adjust all languages to account for these changes.

@hvitvedhvitved added the no-change-note-required This PR does not need a change note label Aug 7, 2023
@hvitved
hvitved marked this pull request as ready for review August 7, 2023 10:49
@hvitved
hvitved requested review from a team as code ownersAugust 7, 2023 10:49
smowton
smowton approved these changes Aug 7, 2023
View reviewed changes

@smowtonsmowton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 👍

michaelnebel
michaelnebel approved these changes Aug 7, 2023
View reviewed changes

@michaelnebelmichaelnebel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 👍

aschackmull
aschackmull approved these changes Aug 7, 2023
View reviewed changes

@aschackmullaschackmull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like some reasonable cleanup 👍

@hvitved
hvitved merged commit 2126ab0 into github:mainAug 7, 2023
@hvitved
hvitved deleted the dataflow/refactor branch August 7, 2023 11:23
@jketemajketema mentioned this pull request Aug 7, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MathiasVPMathiasVPMathiasVP approved these changes
@michaelnebelmichaelnebelmichaelnebel approved these changes
@aschackmullaschackmullaschackmull approved these changes
+1 more reviewer
@smowtonsmowtonsmowton approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C#C++DataFlow LibraryGoJavano-change-note-requiredThis PR does not need a change notePythonRubySwift

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hvitved@smowton@MathiasVP@michaelnebel@aschackmull