Uh oh!
There was an error while loading. Please reload this page.
C#: Use separate newtype branch for AssignableDefinitionNode - #15694
Merged
Conversation
hvitvedforce-pushed
the
csharp/assignable-definition-node
branch
2 times, most recently
from
February 22, 2024 16:10
e3318d3 to
2c8220eComparehvitvedforce-pushed
the
csharp/assignable-definition-node
branch
from
February 22, 2024 20:05
2c8220e to
303a2bbComparehvitved
marked this pull request as ready for review
February 23, 2024 07:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for #15665, this PR adjusts
AssignableDefinitionNodefrom being backed up by an SSA definition node to being backed up by a newnewtypeinjector.The motivation is that SSA definitions only exist for writes that are live, and on #15665 we much simplify which captured variables to construct SSA forms for, so flow through primary constructors cannot rely on the existence of SSA definitions for the captured parameters.
Like #12566 for Ruby, this PR also adds all assignments (i.e.,
AssignableDefinitionNodes) in data flow paths.