Uh oh!
There was an error while loading. Please reload this page.
Go: Use provenance pretty-printing for qlref tests - #17092
Merged
Conversation
owen-mc
commented
Jul 29, 2024
Uh oh!
There was an error while loading. Please reload this page.
owen-mc
commented
Jul 29, 2024
Uh oh!
There was an error while loading. Please reload this page.
owen-mc
commented
Jul 29, 2024
ContributorAuthor
6 tests failed with the following output: |
owen-mcforce-pushed
the
go/provenance-postprocess-qltest
branch
from
July 30, 2024 11:55
33307f9 to
ffeb86cCompareThis commit will be reverted when a bug is fixed which is currently stopping these tests from working with post-processing.
owen-mc
commented
Jul 30, 2024
ContributorAuthor
I rebased on top of #17072, which changed the model numbering. I also added a commit reverting the post-processing for 6 tests which currently hit a bug in the post-processing implementation. When the bug is fixed I will re-convert them, but in the meantime it seems best to merge post-processing for all of the other tests. |
owen-mc
marked this pull request as ready for review
July 30, 2024 12:40
smowton
approved these changes
Jul 31, 2024
smowton
left a comment
Contributor
There was a problem hiding this comment.
Looks plausible except for the duplicate numbering problem already noted
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For qlref tests this uses the new ability to use a post-processing query.