Rust: upgrade `rust-analyzer` to 0.0.274 by redsun82 · Pull Request #19314 · github/codeql

redsun82 · 2025-04-15T14:50:14Z

An outline of included work:

adapting crate_graph.rs to the underlying unstable API changes
updating the rust toolchains, as rust-analyzer requires that.
new rust-analyzer does not expand macros in ASTs that are expanded by attribute macros. Some effort was put into:
- avoiding spamming on macro expansion warnings in the context of an item that needs to be expanded as an attribute macro, by turning off macro expansion in such a context
- from the implementation point of view, this was achieved by renaming the special emit_detached into a more generic post_emit, and adding a corresponding pre_emit: this allows to do the above in terms of the pre_emit/post_emit pair for Item
- tweaking the bad constructor query to work with this (looking into the expanded function bodies rather than the unexpanded ones).

Copilot

Copilot reviewed 109 out of 129 changed files in this pull request and generated no comments.

Files not reviewed (20)

MODULE.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.android_system_properties-0.1.5.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.anstyle-wincon-3.0.7.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.anyhow-1.0.98.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.argfile-0.2.1.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.atomic-0.6.0.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.borsh-1.5.7.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bstr-1.12.0.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bumpalo-3.17.0.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bytemuck-1.22.0.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.byteorder-1.5.0.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.cc-1.2.19.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.chrono-0.4.40.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap-4.5.36.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap_builder-4.5.36.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.crossbeam-channel-0.5.15.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.darling-0.20.11.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.darling_core-0.20.11.bazel: Language not supported
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.darling_macro-0.20.11.bazel: Language not supported

geoffw0 · 2025-05-19T14:15:40Z

+ )
+ )
 or
+ // callable -> callable attribute macro expansion


Is this comment intended to be here?

oh, whoops, this was in a previous version I had, let me fix that, thanks!

geoffw0

QL changes (src and tests) LGTM. 👍

update: oh, wait the spurious comment hasn't been deleted yet.

redsun82 · 2025-05-22T09:48:34Z

QL changes (src and tests) LGTM. 👍
update: oh, wait the spurious comment hasn't been deleted yet.

sorry, I was sure I had done it

geoffw0 · 2025-05-22T11:12:28Z

Extractor changes still need reviewing. I can do it if you're desperate / fairly confident / willing to answer basic questions.

redsun82 · 2025-05-23T14:39:31Z

Extractor changes still need reviewing. I can do it if you're desperate / fairly confident / willing to answer basic questions.

At this point I would have you review the selected out commits in #19572

redsun82 · 2025-05-27T08:07:21Z

obsoleted by #19524

github-actionsBot added the Rust Pull requests that update Rust code label Apr 15, 2025

redsun82 marked this pull request as ready for review April 15, 2025 16:10

CopilotAI review requested due to automatic review settings April 15, 2025 16:10

redsun82 requested review from a team as code owners April 15, 2025 16:10

CopilotAI reviewed Apr 15, 2025
View reviewed changes

redsun82 requested a review from aibaars April 15, 2025 16:10

aibaars previously approved these changes Apr 15, 2025
View reviewed changes

aibaars dismissed their stale review via 29eca23April 17, 2025 11:38

aibaars force-pushed the redsun82/cargo-upgrade-2 branch 2 times, most recently from a85de02 to 5b76400Compare April 18, 2025 10:30

redsun82 requested review from aibaars and geoffw0 May 19, 2025 12:19

geoffw0 reviewed May 19, 2025
View reviewed changes

redsun82 mentioned this pull request May 19, 2025
Rust: upgrade rust-analyzer to 0.0.288 #19524
Merged

redsun82 requested a review from a team as a code owner May 19, 2025 15:23

redsun82 force-pushed the redsun82/cargo-upgrade-2 branch from a615ba1 to 5ec72b2Compare May 19, 2025 15:24

github-actionsBot added the documentation label May 20, 2025

geoffw0 reviewed May 22, 2025
View reviewed changes

Paolo Tranquilli added 5 commits May 23, 2025 12:00

Rust: adapt BadCtorInitialization.ql to attribute macro expansion
32cece3

Rust: skip macro expansion in unexpanded attribute macro AST
abf21ba

Rust: fix BadCtorInitialization test
31b48e1

Rust: enhance macro expansion integration test
5183d16

Rust: remove wrong comment
01e22b7

redsun82 mentioned this pull request May 23, 2025
Rust: turn off macro expansion in code to be expanded by attribute macros #19572
Merged

Rust: update a comment
5c29461

redsun82 marked this pull request as draft May 23, 2025 14:39

Paolo Tranquilliand others added 11 commits May 26, 2025 11:47

Merge branch 'main' into redsun82/rust-macro
add3c94

Cargo: upgrade dependencies
664c60d

Rust: fix compilation after upgrade
8323fed

Rust: update crates.expected after rust version update
9b2f652

Rust: accept test failures for now
c1870f3

Bazel: run cargo update
e8ab5c1

Update root rust-toolchain.toml
faebab8

Rust: revert test expectations
b25b670

Rust: accept new duplicate inconsistencies
862d690

Rust: show unexpanded macro
a3e3202

Rust: accept test changes
9a0f5af

redsun82 force-pushed the redsun82/cargo-upgrade-2 branch from a1b66ff to 9a0f5afCompare May 26, 2025 10:36

Paolo Tranquilli added 4 commits May 26, 2025 13:51

Rust: accept test changes for now
7fbaca0

Rust: fix forgotten merge conflict
b0da58e

Rust: accept test changes
a749cf9

Merge branch 'redsun82/rust-macro' into redsun82/cargo-upgrade-2
165a2ff

redsun82 closed this May 27, 2025

Navigation Menu

Uh oh!

Rust: upgrade `rust-analyzer` to 0.0.274 - #19314

Rust: upgrade `rust-analyzer` to 0.0.274#19314
redsun82 wants to merge 21 commits into
mainfrom
redsun82/cargo-upgrade-2

redsun82 commented Apr 15, 2025•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

geoffw0May 19, 2025

Uh oh!

redsun82May 20, 2025

Uh oh!

geoffw0 left a comment •
edited
Loading

Uh oh!

redsun82 commented May 22, 2025

Uh oh!

geoffw0 commented May 22, 2025

Uh oh!

redsun82 commented May 23, 2025

Uh oh!

redsun82 commented May 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

redsun82 commented Apr 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

geoffw0May 19, 2025

Choose a reason for hiding this comment

Uh oh!

redsun82May 20, 2025

Choose a reason for hiding this comment

Uh oh!

geoffw0 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

redsun82 commented May 22, 2025

Uh oh!

geoffw0 commented May 22, 2025

Uh oh!

redsun82 commented May 23, 2025

Uh oh!

redsun82 commented May 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

redsun82 commented Apr 15, 2025•
edited
Loading

geoffw0 left a comment •
edited
Loading