Uh oh!
There was an error while loading. Please reload this page.
Shared: Use isSink/1 in PropagateFlowConfig - #19404
Merged
Merged
Conversation
MathiasVP
marked this pull request as ready for review
April 28, 2025 17:25
aschackmull
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A not-super-widely-known feature from state-based dataflow configurations is that you can omit the state (see here) in the
isSinkwhen you don't want to restrict the state inisSink.It looks like this is exactly what's being done in
PropagateFlowConfig::isSinkso we might as well omit the sink and avoid the small cartesian product.