Uh oh!
There was an error while loading. Please reload this page.
Rust: Resolve function calls to traits methods - #19575
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
051938a to
e778cbeCompare| // trait bound on the type parameter. | ||
| result = getTypeParameterMethod(receiver.getTypeAt(TypePath::nil()), receiver.getField()) | ||
| ) | ||
| Function resolveMethodCallTarget(MethodCall mc) { |
There was a problem hiding this comment.
This resolveMethodCallTarget was previously getStaticTarget inside MethodCallExpr. But since we now need for CallExpr as well, I've moved it in here.
| methodCandidateTrait(rootType, mc.getTrait(), name, arity, impl) | ||
| or | ||
| not exists(mc.getTrait()) and | ||
| methodCandidate(rootType, name, arity, impl) |
There was a problem hiding this comment.
This new disjunct and methodCandidateTrait is the crux of the change.
hvitved
left a comment
There was a problem hiding this comment.
LGTM. Let's wait for DCA before merging.
| */ | ||
| pragma[nomagic] | ||
| private predicate methodCandidateTrait(Type type, Trait trait, string name, int arity, Impl impl) { | ||
| trait = resolvePath(impl.getTrait().(PathTypeRepr).getPath()) and |
There was a problem hiding this comment.
Alternatively, trait = resolvePath(impl.(ImplItemNode).getTraitPath())
paldepind
commented
May 27, 2025
DCA seems fine to me. "Missing call targets" went down, but I don't think these trait calls where counted as missing before (because there where resolved to the trait itself), so I think the reduction in missing call targets is a secondary effect since some types are now more accurate, and hence some normal method calls can now be resolved. |
This PR adds resolution for function calls to trait methods
ATrait::some_method(obj, ...).Key changes:
MethodCallabstract class that is extended by the different types of expressions that can lead to method calls. Later this class can also be extended by overloaded operators that perform method calls.methodCandidateTraitpredicate, which is similar to the existingmethodCandidatepredicate but which also takes a trait that the method should come from.potentialInstantiationOfnow accounts both for method calls that target a specific trait.