Skip to content

Actions: mass-enable diff-informed queries phase 2 - getASelected{Source,Sink}Location() { none() } - #19757

Merged
d10c merged 1 commit into
github:mainfrom
d10c:d10c/actions/diff-informed-2
Jun 19, 2025
Merged

Actions: mass-enable diff-informed queries phase 2 - getASelected{Source,Sink}Location() { none() }#19757
d10c merged 1 commit into
github:mainfrom
d10c:d10c/actions/diff-informed-2

Conversation

@d10c

@d10cd10c commented Jun 13, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Stacks on top of earlier PR: #19659
Uses patch from: https://github.com/github/codeql-patch/pull/88/commits/ec5681e740c18c792443099fb3e413446616a0ee

Adds getASelected{Source,Sink}Location() { none() } override to queries that select a dataflow source or sink as a location, but not both.

@github-actionsgithub-actionsBot added the Actions Analysis of GitHub Actions label Jun 13, 2025
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jun 13, 2025
View reviewed changes
Comment threadactions/ql/lib/codeql/actions/security/OutputClobberingQuery.qll Fixed
Comment threadactions/ql/lib/codeql/actions/security/OutputClobberingQuery.qll Fixed
Comment threadactions/ql/lib/codeql/actions/security/RequestForgeryQuery.qll Fixed
Comment threadactions/ql/lib/codeql/actions/security/RequestForgeryQuery.qll Fixed
Comment threadactions/ql/lib/codeql/actions/security/SecretExfiltrationQuery.qll Fixed
Comment threadactions/ql/src/Models/ReusableWorkflowsSinks.ql Fixed
Comment threadactions/ql/src/Models/ReusableWorkflowsSources.ql Fixed
Comment threadactions/ql/src/Models/ReusableWorkflowsSources.ql Fixed
Comment threadactions/ql/src/Models/ReusableWorkflowsSummaries.ql Fixed
Comment threadactions/ql/src/Models/ReusableWorkflowsSummaries.ql Fixed
@d10c
d10cforce-pushed the d10c/actions/diff-informed-2 branch from ce9c6af to 08a72efCompareJune 13, 2025 13:12
@d10cd10c mentioned this pull request Jun 13, 2025
Merged
@d10c
d10c marked this pull request as ready for review June 17, 2025 08:39
@d10c
d10c requested a review from a team as a code ownerJune 17, 2025 08:40
@d10cd10c added the no-change-note-required This PR does not need a change note label Jun 17, 2025
@d10c
d10c requested a review from michaelnebelJune 17, 2025 12:54
@d10c
d10cforce-pushed the d10c/actions/diff-informed-2 branch from 08a72ef to fc61910CompareJune 17, 2025 15:00
michaelnebel
michaelnebel approved these changes Jun 19, 2025
View reviewed changes

@michaelnebelmichaelnebel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d10c
d10c merged commit 699c82a into github:mainJun 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelnebelmichaelnebelmichaelnebel approved these changes

Assignees

No one assigned

Labels

ActionsAnalysis of GitHub Actionsno-change-note-requiredThis PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d10c@michaelnebel@github-advanced-security