Skip to content

C#: mass-enable diff-informed queries phase 2 - getASelected{Source,Sink}Location() { none() } - #19758

Merged
d10c merged 1 commit into
github:mainfrom
d10c:d10c/csharp/diff-informed-2
Jun 19, 2025
Merged

C#: mass-enable diff-informed queries phase 2 - getASelected{Source,Sink}Location() { none() }#19758
d10c merged 1 commit into
github:mainfrom
d10c:d10c/csharp/diff-informed-2

Conversation

@d10c

@d10cd10c commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Stacks on top of earlier PR: #19659
Uses patch from: https://github.com/github/codeql-patch/pull/88/commits/ec5681e740c18c792443099fb3e413446616a0ee

Adds getASelected{Source,Sink}Location() { none() } override to queries that select a dataflow source or sink as a location, but not both.

@d10c
d10cforce-pushed the d10c/csharp/diff-informed-2 branch from 6d8f13c to 9fde7ceCompareJune 13, 2025 13:10
@d10c
d10c marked this pull request as ready for review June 17, 2025 08:39
@d10c
d10c requested a review from a team as a code ownerJune 17, 2025 08:39
@d10c
d10c requested a review from michaelnebelJune 17, 2025 08:39
@d10cd10c added the no-change-note-required This PR does not need a change note label Jun 17, 2025
@d10c
d10cforce-pushed the d10c/csharp/diff-informed-2 branch from 9fde7ce to 634bfa9CompareJune 17, 2025 15:00

@michaelnebelmichaelnebel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this LGTM, since the 0'th column (the primary) in the select of the query is the sink and since the source is not used as an additional location (i.e. "$@" substitution).

@d10c
d10c merged commit 8e22326 into github:mainJun 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C#no-change-note-requiredThis PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@d10c@michaelnebel@github-advanced-security