Skip to content

C++: Support more complex 16-bit float types - #19862

Merged
jketema merged 1 commit into
github:mainfrom
jketema:complex
Jun 24, 2025
Merged

C++: Support more complex 16-bit float types#19862
jketema merged 1 commit into
github:mainfrom
jketema:complex

Conversation

@jketema

@jketemajketema commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-securityAI found potential problems Jun 24, 2025
View reviewed changes
Comment threadcpp/ql/lib/semmle/code/cpp/Type.qll Fixed
Comment threadcpp/ql/lib/semmle/code/cpp/Type.qll Fixed
Comment threadcpp/ql/lib/semmle/code/cpp/Type.qll Fixed
Comment threadcpp/ql/lib/semmle/code/cpp/Type.qll Fixed
Comment threadcpp/ql/lib/semmle/code/cpp/Type.qll Fixed
Comment threadcpp/ql/lib/semmle/code/cpp/Type.qll Fixed
@jketema
jketemaforce-pushed the complex branch 2 times, most recently from 4159bce to 2843a59CompareJune 24, 2025 09:46
jketema
jketema commented Jun 24, 2025
View reviewed changes
Comment threadcpp/ql/lib/semmlecode.cpp.dbscheme.stats
Comment on lines +339 to +350
<e>
<k>@complex_fp16</k>
<v>124</v>
</e>
<e>
<k>@complex_std_bfloat16</k>
<v>124</v>
</e>
<e>
<k>@complex_std_float16</k>
<v>124</v>
</e>

@jketemajketemaJun 24, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I just hacked this in, as stats file generation is currently broken. I do a proper update once that is fixed.

@jketema
jketema marked this pull request as ready for review June 24, 2025 10:30
@jketema
jketema requested a review from a team as a code ownerJune 24, 2025 10:30
@jketemajketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jun 24, 2025
andersfugmann
andersfugmann approved these changes Jun 24, 2025
View reviewed changes

@andersfugmannandersfugmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM.

IdrissRio
IdrissRio approved these changes Jun 24, 2025
View reviewed changes

@IdrissRioIdrissRio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise LGTM

Comment threadcpp/ql/lib/change-notes/2025-06-24-float16.md
@andersfugmann

andersfugmann commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Approving - assuming this will not merge before checks are green :-)

@jketema
jketema merged commit 9a83005 into github:mainJun 24, 2025
@jketema
jketema deleted the complex branch June 24, 2025 15:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andersfugmannandersfugmannandersfugmann approved these changes
@IdrissRioIdrissRioIdrissRio approved these changes

Assignees

No one assigned

Labels

C++depends on internal PRThis PR should only be merged in sync with an internal Semmle PRdocumentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jketema@andersfugmann@IdrissRio@github-advanced-security