Skip to content

Ruby: Do not compute StringlikeLiteralImpl.getStringValue for large strings - #19926

Merged
hvitved merged 1 commit into
github:mainfrom
hvitved:ruby/restrict-string-component-length
Jul 1, 2025
Merged

Ruby: Do not compute StringlikeLiteralImpl.getStringValue for large strings#19926
hvitved merged 1 commit into
github:mainfrom
hvitved:ruby/restrict-string-component-length

Conversation

@hvitved

@hvitvedhvitved commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Fixes the PoolGrowthError "String too long (2160871 characters)" error we have seen at a customer.

@hvitved
hvitvedforce-pushed the ruby/restrict-string-component-length branch from 550f14c to 41a403cCompareJune 30, 2025 11:02
@hvitvedhvitved added the no-change-note-required This PR does not need a change note label Jun 30, 2025
@hvitved
hvitved marked this pull request as ready for review June 30, 2025 17:57
CopilotAI review requested due to automatic review settings June 30, 2025 17:57
@hvitved
hvitved requested a review from a team as a code ownerJune 30, 2025 17:57

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@hvitved
hvitved requested a review from asgerfJuly 1, 2025 07:04

@aibaarsaibaars left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@hvitved
hvitved merged commit 219a622 into github:mainJul 1, 2025
@hvitved
hvitved deleted the ruby/restrict-string-component-length branch July 1, 2025 10:45
@evK1

evK1 commented Jul 3, 2025

Copy link
Copy Markdown

Thanks for fixing this!

Ditto !

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-requiredThis PR does not need a change noteRuby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hvitved@evK1@aibaars