Uh oh!
There was an error while loading. Please reload this page.
Diff-informed queries: phase 3 (non-trivial locations) - #19957
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ff3a4b9 to
95fe462CompareUh oh!
There was an error while loading. Please reload this page.
aff62c2 to
6d0ae3aCompare| @@ -0,0 +1 @@ | |||
| experimental/Security/CWE-208/TimingAttackAgainstHash/TimingAttackAgainstHash.ql | |||
Check warning
Code scanning / CodeQL
Query test without inline test expectations
c871f5e to
276c7f0CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cb2db2f to
c70036dCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
c70036d to
08c4cc2CompareUh oh!
There was an error while loading. Please reload this page.
857b583 to
3e3e856Compared10c
commented
Jul 15, 2025
DCA results: some slowdowns on Python, but they don't seem to be related to these changes. Java had some timeout-related failures, so I'll restart that. Overall, no negative performance impact on empty-diff. |
443655d to
5112a9cCompare5112a9c to
085720aComparemichaelnebel
commented
Jul 17, 2025
This is a very large diff for a single PR. Would it be a lot of extra work to split this into one PR per language? Then it will also be possible to merge a bit at the time (there might be issues with getting DCA running successfully for this many languages and it will be a shame to block merging changes while waiting for DCA/review for other languages). |
d10c
commented
Jul 17, 2025
Sure, I can split it off into separate PRs per language. |
michaelnebel
commented
Jul 17, 2025
Thank you - that will be really appreciated. You also structured the commits very nicely, so it seems doable 😄 |
This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actually selected.
Prior work includes PRs like #19663, #19759, and #19817. This PR uses the same patch script as those PRs to find candidate queries to convert to diff-enabled. This is the final step in mass-enabling diff-informed queries on all the languages.
Commit-by-commit reviewing is recommended.
Potentially tricky cases:
--check-diff-informedlocally and in CI. Should create a follow-up issue.where, or if it's good enough to overapproximate and just pass the--check-diff-informedtests.