Uh oh!
There was an error while loading. Please reload this page.
C#/Java/Rust: Improve database quality diagnostics query. - #20366
Merged
michaelnebel merged 10 commits intoSep 8, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
michaelnebelforce-pushed
the
csharp/improvedatabasequalitydiagnostics
branch
3 times, most recently
from
September 4, 2025 13:17
6b0657b to
cafe644CompareContributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the database quality diagnostics message for C# by including specific health metrics in the diagnostic output. The enhancement provides users with concrete percentage values for call targets and expression types to help them better understand database quality issues.
Key changes:
- Enhanced diagnostic message to include specific database health metrics with percentage values
- Refactored the diagnostic creation logic to capture and display both call target and expression type statistics
- Updated expected test outputs to reflect the new message format
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csharp/ql/src/change-notes/2025-09-04-database-diagnostics.md | Documents the enhancement to include database health metrics in diagnostic messages |
| csharp/ql/src/Telemetry/DatabaseQualityDiagnostics.ql | Refactors diagnostic logic to capture specific metrics and updates the diagnostic message format |
| csharp/ql/integration-tests/all-platforms/standalone/DatabaseQualityDiagnostics.expected | Updates expected test output to match the new diagnostic message format |
michaelnebelforce-pushed
the
csharp/improvedatabasequalitydiagnostics
branch
from
September 4, 2025 13:31
cafe644 to
02e2b65Comparemichaelnebelforce-pushed
the
csharp/improvedatabasequalitydiagnostics
branch
from
September 5, 2025 09:17
02e2b65 to
70b3a46Comparemichaelnebel
marked this pull request as ready for review
September 5, 2025 10:40
redsun82
reviewed
Sep 8, 2025
| private string getDbHealth() { | ||
| result = | ||
| callMsg + ": " + callTargetOk.floor() + ". " + exprMsg + ": " + exprTypeOk.floor() + ". " |
Contributor
There was a problem hiding this comment.
maybe
Suggested change
| callMsg+": "+callTargetOk.floor()+". "+exprMsg+": "+exprTypeOk.floor()+". " | |
| callMsg+": "+callTargetOk.floor()+"%. "+exprMsg+": "+exprTypeOk.floor()+"%. " |
?
hvitved
reviewed
Sep 8, 2025
| | | ||
| percentageGood < 95 | ||
| ) | ||
| TTheDbQualityDiagnostic(string callMsg, float callTargetOk, string exprMsg, float exprTypeOk) { |
Contributor
There was a problem hiding this comment.
How about instead:
privatepredicatediagnostic(stringmsg,floatvalue,floatthreshold){
CallTargetStatsReport::percentageOfOk(msg,value)andthreshold=85or
ExprTypeStatsReport::percentageOfOk(msg,value)andthreshold=85}privatenewtypeTDbQualityDiagnostic=TTheDbQualityDiagnostic(){exists(floatpercentageGood,floatthreshold|diagnostic(_,percentageGood,threshold)andpercentageGood<threshold)}
...
privatestringgetDbHealth(){result=strictconcat(stringmsg,floatvalue,floatthreshold|diagnostic(msg,value,threshold)|msg+": "+value.floor()+" % (threshold "+threshold.floor()+" %)",". ")}ContributorAuthor
There was a problem hiding this comment.
Yes, considering the discussion on the posibility of having different thresholds pr metric - then this looks very good.
I will address the review comments for C# and when we have reached consensus, I will update for the other languages as well (in this PR).
michaelnebel
marked this pull request as draft
September 8, 2025 09:50
michaelnebelforce-pushed
the
csharp/improvedatabasequalitydiagnostics
branch
from
September 8, 2025 10:06
ae516ee to
29c22e6CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.