Skip to content

C#: Use .NET 10 for building the extractor and running tests. - #20898

Merged
michaelnebel merged 14 commits into
github:mainfrom
michaelnebel:csharp/dotnet10extractor
Dec 11, 2025
Merged

C#: Use .NET 10 for building the extractor and running tests. #20898
michaelnebel merged 14 commits into
github:mainfrom
michaelnebel:csharp/dotnet10extractor

Conversation

@michaelnebel

@michaelnebelmichaelnebel commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

In this PR we

@michaelnebel
michaelnebelforce-pushed the csharp/dotnet10extractor branch 10 times, most recently from 5bbbb72 to 83afda0CompareDecember 1, 2025 09:41
@michaelnebel
michaelnebelforce-pushed the csharp/dotnet10extractor branch 6 times, most recently from 45ce20d to 71ebbfeCompareDecember 9, 2025 10:53
@michaelnebelmichaelnebel changed the title C#: Build extractor using .NET 10.C#: Use .NET 10 for building the extractor and running tests. Dec 9, 2025
@michaelnebel
michaelnebel marked this pull request as ready for review December 9, 2025 14:59
@michaelnebel
michaelnebel requested a review from a team as a code ownerDecember 9, 2025 14:59
CopilotAI review requested due to automatic review settings December 9, 2025 14:59
@michaelnebel
michaelnebel requested review from a team as code ownersDecember 9, 2025 14:59

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the C# extractor and testing infrastructure from .NET 9 to .NET 10, including updates to build tooling, integration tests, and test stubs.

  • Updates .NET SDK from 9.0.300/9.0.304 to 10.0.100
  • Upgrades Bazel rules_dotnet to 0.21.5 with custom patches
  • Migrates target framework from net9.0 to net10.0 across all projects and tests

Reviewed changes

Copilot reviewed 297 out of 301 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
misc/bazel/registry/modules/rules_dotnet/0.21.5-codeql.1/source.jsonUpdates rules_dotnet source URL and integrity hash to version 0.21.5
misc/bazel/registry/modules/rules_dotnet/0.21.5-codeql.1/MODULE.bazelAdds new MODULE.bazel configuration for rules_dotnet 0.21.5 with .NET 10.0.100 toolchain
misc/bazel/registry/modules/rules_dotnet/0.19.2-codeql.1/MODULE.bazelRemoves obsolete MODULE.bazel for rules_dotnet 0.19.2
misc/bazel/csharp.bzlUpdates TARGET_FRAMEWORK constant from net9.0 to net10.0
csharp/scripts/stubs/helpers.pyUpdates stub generation scripts to use .NET 10 SDK and target framework
csharp/scripts/gen-assembly-info.pyUpdates assembly info to reference .NET 10.0 instead of 9.0
csharp/scripts/create-extractor-pack.shUpdates RuntimeFrameworkVersion to 10.0.0 for publishing
csharp/ql/test/utils/modeleditor/ApplicationModeEndpoints.expectedUpdates expected test output from version 9.0.0.0 to 10.0.0.0
csharp/ql/test/resources/stubs/**/*.csprojUpdates target framework from net9.0 to net10.0 in test stub projects
csharp/ql/test/library-tests/**/*.expectedUpdates expected test outputs to reflect .NET 10 assembly versions
csharp/ql/lib/change-notes/2025-12-09-bmn-default-dotnet.mdAdds change note documenting .NET 10 as default for build mode: none
csharp/ql/integration-tests/**/*.csprojUpdates target framework from net9.0 to net10.0 in integration test projects
csharp/ql/integration-tests/**/global.jsonUpdates SDK version from 9.0.304 to 10.0.100 in integration tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@michaelnebel

Copy link
Copy Markdown
ContributorAuthor

@redsun82 : It looks like we need to re-apply the patch for dotnet_rules. Do you think it makes sense to get patch into rules_dotnet main?

@hvitvedhvitved left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me (I don't really know much about Bazel/paket).

@michaelnebel
michaelnebelforce-pushed the csharp/dotnet10extractor branch from 71ebbfe to c69bbceCompareDecember 11, 2025 10:36
@michaelnebel
michaelnebel merged commit c79cdea into github:mainDec 11, 2025
30 of 79 checks passed
@michaelnebel
michaelnebel deleted the csharp/dotnet10extractor branch December 11, 2025 11:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelnebel@hvitved