Uh oh!
There was an error while loading. Please reload this page.
JS: Use question-mark variant in all overlay annotations - #20985
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates overlay annotations across the JavaScript QL library by adding the question-mark suffix (?) to make them optional variants, avoiding breaking changes in the rc/3.20 release.
- Systematically replaces
overlay[local]withoverlay[local?]andoverlay[caller]withoverlay[caller?] - Changes are purely mechanical and affect only annotation syntax, not code logic
Reviewed changes
Copilot reviewed 73 out of 73 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| InlineSummaries.qll | Updated overlay annotation for test summary class |
| StmtContainers.qll | Updated module and method overlay annotations |
| Overlay.qll | Updated overlay annotations for overlay detection predicates |
| CachedStages.qll | Updated overlay annotations for cached stage modules |
| BasicBlockInternal.qll | Updated module and dominator predicate overlay annotations |
| ApiGraphModelsSpecific.qll | Updated overlay annotations for API graph model predicates |
| ModelsAsData.qll | Updated overlay annotation for summarized callable class |
| UriLibraries.qll | Updated overlay annotation for query string class |
| Templating.qll | Updated module overlay annotation |
| PropertyProjection.qll | Updated module overlay annotation |
| NodeJSLib.qll | Updated overlay annotations for Node.js-related predicates |
| LodashUnderscore.qll | Updated overlay annotations for Lodash/Underscore classes and predicates |
| LazyCache.qll | Updated module overlay annotation |
| AngularJSCore.qll | Updated overlay annotation for Angular reference predicate |
| Ssa.qll (sharedlib) | Updated module overlay annotation |
| VariableOrThis.qll | Updated module overlay annotation |
| VariableCapture.qll | Updated module overlay annotation |
| FlowSummaryPrivate.qll | Updated module overlay annotation |
| FlowSteps.qll | Updated overlay annotation for identity function step |
| DataFlowPrivate.qll | Updated module and inline predicate overlay annotations |
| DataFlowNode.qll | Updated module overlay annotation |
| Contents.qll | Updated module and content set predicate overlay annotations |
| AdditionalFlowInternal.qll | Updated overlay annotations for flow synthesis predicates |
| AccessPaths.qll | Updated module overlay annotation |
| AbstractValuesImpl.qll | Updated module overlay annotation |
| Sources.qll | Updated module overlay annotation |
| Refinements.qll | Updated module overlay annotation |
| Nodes.qll | Updated module overlay annotation |
| InferredTypes.qll | Updated module overlay annotation |
| FlowSummary.qll | Updated module overlay annotation |
| DataFlow.qll | Updated module overlay annotation |
| CustomAbstractValueDefinitions.qll | Updated module overlay annotation |
| Configuration.qll | Updated overlay annotations for pseudo-property predicates |
| AdditionalFlowSteps.qll | Updated overlay annotation for additional flow step class |
| AbstractValues.qll | Updated module overlay annotation |
| YAML.qll | Updated module overlay annotation |
| XML.qll | Updated module overlay annotation |
| Variables.qll | Updated module overlay annotation |
| TypeScript.qll | Updated module overlay annotation |
| TypeAnnotations.qll | Updated module overlay annotation |
| Tokens.qll | Updated module overlay annotation |
| Templates.qll | Updated module overlay annotation |
| Stmt.qll | Updated module overlay annotation |
| SSA.qll | Updated module overlay annotation |
| Regexp.qll | Updated module overlay annotation |
| Promises.qll | Updated overlay annotations for promise pseudo-field predicates |
| NodeJS.qll | Updated overlay annotations for Node.js module class and predicates |
| Modules.qll | Updated module overlay annotation |
| Locations.qll | Updated module and location comparison overlay annotations |
| Lines.qll | Updated module overlay annotation |
| JSX.qll | Updated module overlay annotation |
| JSON.qll | Updated module overlay annotation |
| JSDoc.qll | Updated module overlay annotation |
| HTML.qll | Updated module overlay annotation |
| GlobalAccessPaths.qll | Updated module and access path predicate overlay annotations |
| Functions.qll | Updated module overlay annotation |
| Files.qll | Updated module overlay annotation |
| Externs.qll | Updated module overlay annotation |
| Extend.qll | Updated module overlay annotation |
| Expr.qll | Updated module and exception handling overlay annotations |
| Errors.qll | Updated module overlay annotation |
| ES2015Modules.qll | Updated module overlay annotation |
| E4X.qll | Updated module overlay annotation |
| DefUse.qll | Updated module overlay annotation |
| Constants.qll | Updated module overlay annotation |
| Comments.qll | Updated module overlay annotation |
| Closure.qll | Updated module overlay annotation |
| Classes.qll | Updated module overlay annotation |
| CFG.qll | Updated module overlay annotation |
| AST.qll | Updated module and flow method overlay annotations |
| AMD.qll | Updated module overlay annotation |
| UnusedIndexVariable.qll | Updated module overlay annotation |
| ExprHasNoEffect.qll | Updated module overlay annotation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
redsun82
approved these changes
Dec 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
overlay[local]withoverlay[local?]and likewiseoverlay[caller] -> overlay[caller?]to avoid breaking changes for now.Note: this PR is targeting the release branch