Rust: Upgrade to rust-analyzer 0.328 by tausbn · Pull Request #21714 · github/codeql

tausbn · 2026-04-15T14:59:25Z

WIP. Let's see what the CI thinks of this. (For the avoidance of doubt, Copilot wrote all of the code, and I'm still working my way through the changes themselves.)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…scripts - Fix Meta usage: Meta is now abstract with subtypes (PathMeta, KeyValueMeta, TokenTreeMeta, etc.) - Fix FormatArgsArg: getName() replaced by getArgName() returning FormatArgsArgName - Add upgrade script (old → new) and downgrade script (new → old) - Update Definitions.qll, PathResolution.qll, BadCtorInitialization.ql, FormatTemplateVariableAccessConstructor.qll Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Re-run cargo fmt after clippy --fix to ensure consistent formatting. Re-run codegen to update generated file tracking for MetaImpl.qll. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Setting proc_macro_processes to 0 causes an index-out-of-bounds panic in ProcMacroServerPool::new when the proc macro server is enabled. Use the same defaults as rust-analyzer itself (1 each). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Remove format_args_arg_names from upgrade delete list (table exists in both schemas with different columns) - Accept updated .expected files for schema changes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Exclude macro-expanded and attribute paths from PathResolutionConsistency (tokio::main and similar attribute macros resolve to multiple proc macro fns) - Exclude "macro expansion failed" warnings from ExtractionConsistency (compile_error! and undefined macros are expected to fail expansion) - Update pre-existing consistency expectations (net multipleResolvedTargets) - Update type-inference.expected for new RA results Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Rust: Restore built-in derive macro expansion under rust-analyzer 0.0.328

Regenerated Cargo.lock, Bazel 3rdparty deps, and CodeQL rust generated files. Rebased the 0.328 dbscheme upgrade/downgrade scripts onto main's schema chain (66a489 -> 77e9a70 -> e1bce49 -> M). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Collapse nested `if let`/`if` into let-chains (edition 2024) in tree-sitter-extractor and add an explicit `'_` lifetime in yeast, as required by clippy under the new toolchain. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

The rust-analyzer 0.0.328 upgrade changed the ra_ap_syntax_bridge import in rust/extractor/src/translate/base.rs to a single line that exceeds the max width, causing the rust-code CI job to fail at cargo fmt --check. Wrap the import so cargo fmt --check passes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

`should_be_excluded` only resolved a crate for items in real files. Items coming from a macro expansion live in a `MacroFile`, for which `HirFileId::file_id()` returns `None`, so the cfg was never checked and both branches of e.g. `#[cfg(feature = "rt")]` / `#[cfg(not(feature = "rt"))]` were extracted. Recover the crate from the macro call in that case, mirroring the crate resolution the old upstream `Semantics::check_cfg_attr` performed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4ee033fb-30ad-4617-9922-bc0f1088ba81

Regression test for `should_be_excluded`: items produced by a macro expansion carrying a disabled `#[cfg(...)]` must be excluded from extraction, just like disabled items written directly in a source file. Uses `cfg(any())`/`cfg(all())` so the test does not depend on crate features. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4ee033fb-30ad-4617-9922-bc0f1088ba81

Apply .expected diffs from the Rust Language Tests CI runs following the cfg-exclusion fix: duplicate flow rows from macro/cfg double-extraction are removed and platform-gated models no longer double-load, which clears the associated consistency violations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4ee033fb-30ad-4617-9922-bc0f1088ba81

hvitved

I'm now happy with this PR; let's see what the (hopefully final) DCA run has to say.

…-to-rust-analyzer-0.0.328

hvitved · 2026-08-13T13:49:15Z

Rerun has been triggered: 2 restarted 🚀

hvitved · 2026-08-14T06:29:45Z

The final DCA run looks great:

All projects succeed analysis 🎉.
Percentage of calls with call target is back at 85 % (from 66 %).
Average extraction time, database size, and analysis time has doubled, which is because we simply extract more stuff that we were missing after the Rust 1.95.0 upgrade (for example expanded macros).
Extraction warnings down from 321k to 62k (for example macro invocations that we were previously not able to resolve).
Lots of new alerts as a result of improved extraction.
Lots of 'unused variable' alerts eliminated, presumably instances of Rust: False positive for unused variable names #22342.

tausbnand others added 6 commits April 15, 2026 12:54

Cargo: upgrade dependencies
ab75d99

Bazel: regenerate vendored cargo dependencies
1234471

Rust: update rust-analyzer source and run codegen
5f76c94

Rust: adapt extractor to rust-analyzer 0.0.328 API changes
ce360c4

Rust: update toolchain to 1.91 and apply lint fixes
35fc6fb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actionsBot added Ruby Rust Pull requests that update Rust code labels Apr 15, 2026

tausbn changed the title ~~Rust: Upgrade to rusts-analyzer 0.328~~Rust: Upgrade to rust-analyzer 0.328Apr 15, 2026

github-advanced-securityBot found potential problems Apr 15, 2026
View reviewed changes

tausbnand others added 5 commits April 15, 2026 15:12

Rust: fix formatting and codegen drift
8747228
Re-run cargo fmt after clippy --fix to ensure consistent formatting. Re-run codegen to update generated file tracking for MetaImpl.qll. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Rust: fix upgrade script and update test expectations
6057c79
- Remove format_args_arg_names from upgrade delete list (table exists in both schemas with different columns) - Accept updated .expected files for schema changes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Rust: fix downgrade script (same format_args_arg_names issue)
1bd0821
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tausbn force-pushed the tausbn/rust-upgrade-to-rust-analyzer-0.0.328 branch from c990d17 to ac27c20Compare April 16, 2026 14:15

tausbnand others added 2 commits April 16, 2026 20:31

Rust: fix downgrade script - add missing block_expr_try_block_modifiers
f66f82c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge origin/main into rust analyzer upgrade
60bffd0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-advanced-securityBot found potential problems May 22, 2026
View reviewed changes

Comment threadrust/ql/lib/codeql/rust/elements.qll Dismissed
Comment threadrust/ql/lib/codeql/rust/elements.qll Dismissed
Comment threadrust/ql/lib/codeql/rust/elements.qll Dismissed
Comment threadrust/ql/lib/codeql/rust/elements.qll Dismissed

Rust: accept test changes
a2ecf65

redsun82 marked this pull request as ready for review May 22, 2026 15:35

CopilotAI review requested due to automatic review settings May 22, 2026 15:35

redsun82 requested review from a team as code owners May 22, 2026 15:35

CopilotAI reviewed May 22, 2026

redsun82 requested a review from geoffw0 May 22, 2026 15:58

redsun82 mentioned this pull request Aug 3, 2026
Rust: Restore built-in derive macro expansion under rust-analyzer 0.0.328 #22273
Merged

redsun82and others added 3 commits August 3, 2026 17:10

Merge pull request#22273from github/redsun82-rust-derive-macro-patch
bbd2102
Rust: Restore built-in derive macro expansion under rust-analyzer 0.0.328

Rust: Add change note for rust-analyzer 0.0.328 upgrade
76140a6
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actionsBot added the documentation label Aug 3, 2026

redsun82and others added 2 commits August 3, 2026 18:03

mario4tier mentioned this pull request Aug 7, 2026
[Rust] macro expansion failed warnings 2 #19982
Open

hvitvedand others added 6 commits August 10, 2026 14:14

Rust: Accept more inconsistencies
6a6931c

Rust: Revert change in multipleResolvedTargets
c972bb8

Rust: Minor cleanup
3fd1909

hvitved force-pushed the tausbn/rust-upgrade-to-rust-analyzer-0.0.328 branch from dec6758 to 3fd1909Compare August 10, 2026 14:31

hvitved previously approved these changes Aug 10, 2026
View reviewed changes

hvitved dismissed their stale review via 4be3dc4August 13, 2026 13:08

github-actionsBot added the DataFlow Library label Aug 13, 2026

Merge remote-tracking branch 'upstream/main' into tausbn/rust-upgrade…
5116c99
…-to-rust-analyzer-0.0.328

hvitved force-pushed the tausbn/rust-upgrade-to-rust-analyzer-0.0.328 branch from 4be3dc4 to 5116c99Compare August 13, 2026 13:10

github-actionsBot removed the DataFlow Library label Aug 13, 2026

hvitved mentioned this pull request Aug 13, 2026
Rust: False positive for unused variable names #22342
Open

hvitved approved these changes Aug 14, 2026
View reviewed changes

hvitved merged commit e5f5e5b into mainAug 14, 2026
126 checks passed

hvitved deleted the tausbn/rust-upgrade-to-rust-analyzer-0.0.328 branch August 14, 2026 06:30

cryptskii mentioned this pull request Aug 15, 2026
ci: restore CodeQL security analysis (off since 2026-03-26), and fix Rust macro extraction deterministicstatemachine/dsm#660
Merged

bmachek mentioned this pull request Aug 20, 2026
Pin the CodeQL Rust toolchain to 1.94 LrGenius/LrGeniusAI#297
Merged

hvitved mentioned this pull request Aug 31, 2026
Rust: query evaluation ~15× slower on 2.26.4 vs 2.26.3 (4 min → 45–60 min, type-inference/data-flow stage) #22463
Open

Navigation Menu

Uh oh!

Rust: Upgrade to rust-analyzer 0.328 - #21714

Rust: Upgrade to rust-analyzer 0.328#21714
hvitved merged 39 commits into
mainfrom
tausbn/rust-upgrade-to-rust-analyzer-0.0.328

tausbn commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Uh oh!

hvitved left a comment

Uh oh!

hvitved commented Aug 13, 2026•
edited by codeql-ci-app Bot
Loading

Uh oh!

hvitved commented Aug 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

tausbn commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Uh oh!

hvitved left a comment

Choose a reason for hiding this comment

Uh oh!

hvitved commented Aug 13, 2026• edited by codeql-ci-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hvitved commented Aug 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hvitved commented Aug 13, 2026•
edited by codeql-ci-app Bot
Loading