Uh oh!
There was an error while loading. Please reload this page.
Python: Implement ContentApprox - #21941
Merged
Merged
Conversation
hvitvedforce-pushed
the
python/content-approx
branch
from
June 7, 2026 19:12
5b63483 to
dc58e2fComparehvitvedforce-pushed
the
python/content-approx
branch
from
June 8, 2026 06:41
dc58e2f to
cc1ea25CompareContributorAuthor
Rerun has been triggered: 4 restarted 🚀 |
ContributorAuthor
ContributorAuthor
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a concrete ContentApprox representation for Python’s new dataflow internals, enabling a more structured approximation of Content (including dictionary elements and attribute content) to help recover performance lost after earlier precision improvements.
Changes:
- Add helper predicates to derive a stable “first non-underscore character” approximation from strings used in content representations.
- Introduce
TContentApproxand implementContentApproxas a propernewtype-backed class. - Implement
getContentApprox(Content c)to map preciseContentvariants into the new approximation domain.
Show a summary per file
| File | Description |
|---|---|
| python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll | Defines ContentApprox as a real approximation type and implements mapping from Content into this approximation. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
owen-mc
approved these changes
Jun 9, 2026
owen-mc
left a comment
Contributor
There was a problem hiding this comment.
Looks good. DCA shows improvement in one of the two projects that regressed a lot from the previous PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21888 follow-up.
DCA shows a noticeable improvement for
ytdl-org__youtube-dl, recovering performance lost from the PR mentioned above (this DCA run shows the combination of the two PRs).