Uh oh!
There was an error while loading. Please reload this page.
Swift: Turn off caching and integrated driver in autobuild - #22111
Merged
Conversation
jketema
marked this pull request as ready for review
July 2, 2026 15:09
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Swift autobuilder’s xcodebuild invocation to avoid Swift compilation caching and the integrated driver, which can otherwise lead to missing compiler invocations (nearly empty databases) or dependence on Xcode-shipped modules that the extractor can’t handle.
Changes:
- Add Xcode build settings to disable compilation caching and the integrated driver in
swift-autobuilder. - Update
swift-autobuildertest golden files to match the newxcodebuildcommand-line. - Adjust Swift Xcode integration tests to pass
SWIFT_USE_INTEGRATED_DRIVER=NO, and simplify one autobuilder integration test’s markers/expectations.
Show a summary per file
| File | Description |
|---|---|
| swift/swift-autobuilder/tests/hello-workspace/commands.expected | Updates expected xcodebuild command to include cache + integrated-driver disabling settings. |
| swift/swift-autobuilder/tests/hello-tests/commands.expected | Updates expected xcodebuild command to include cache + integrated-driver disabling settings. |
| swift/swift-autobuilder/tests/hello-targets-with-tests-suffix/commands.expected | Updates expected xcodebuild command to include cache + integrated-driver disabling settings. |
| swift/swift-autobuilder/tests/hello-autobuilder/commands.expected | Updates expected xcodebuild command to include cache + integrated-driver disabling settings. |
| swift/swift-autobuilder/BuildRunner.cpp | Adds xcodebuild build settings to disable compilation caching and the integrated driver for Xcode target builds. |
| swift/ql/integration-tests/osx/hello-xcode/test.py | Adds SWIFT_USE_INTEGRATED_DRIVER=NO to the integration test’s explicit xcodebuild command. |
| swift/ql/integration-tests/osx/hello-ios/test.py | Adds SWIFT_USE_INTEGRATED_DRIVER=NO to the integration test’s explicit xcodebuild command. |
| swift/ql/integration-tests/autobuilder/xcode-fails-spm-works/test.py | Simplifies ql-test markers, making DB-CHECK unconditionally xfailed. |
| swift/ql/integration-tests/autobuilder/xcode-fails-spm-works/Files.macos_26.expected | Removes macOS-26-specific expected output variant. |
| swift/ql/integration-tests/autobuilder/failure/diagnostics.expected | Updates diagnostic expected output to include the new xcodebuild settings in the reported command. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 2
- Review effort level: Low
Comment on lines
+12
to
+13
| "CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO " | ||
| "SWIFT_USE_INTEGRATED_DRIVER=NO", |
ContributorAuthor
There was a problem hiding this comment.
Technically, yes, but this project was not set up with caching enabled.
Comment on lines
+10
to
+11
| "CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO " | ||
| "SWIFT_USE_INTEGRATED_DRIVER=NO", |
ContributorAuthor
There was a problem hiding this comment.
Technically, yes, but this project was not set up with caching enabled.
* Caching cases compiler invocations to be omitted. You can try this for yourself by turning on caching while building the project from the `xcode-hello` integration test, then cleaning of the build artifacts and building the project again while caching is enabled. This yields a database that is practically empty. * The integrated driver causes compiler invocations to depend on modules shipped with Xcode. Those are unfortunately incompatible with our extractor.
jketemaforce-pushed
the
jketema/swift-more-autobuild
branch
from
July 8, 2026 07:36
4ecaf49 to
36af59aComparegeoffw0
approved these changes
Jul 20, 2026
geoffw0
left a comment
Contributor
There was a problem hiding this comment.
LGTM (some details discussed in another channel).
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xcode-hellointegration test, then cleaning of the build artifacts and building the project again while caching is enabled. This yields a database that is practically empty.For clarity: Earlier Xcode versions seem to silently ignore the additional options, so there is no direct need to determine what the Xcode version is.
The QA experiment that links here is a bit messy due to QA timing out. See the link in the very last comment I posted for something that approximates a complete experiment.