Uh oh!
There was an error while loading. Please reload this page.
C#: Remove the query cs/useless-assignment-to-local from the code-quality suite. - #22193
Merged
michaelnebel merged 3 commits intoJul 16, 2026
Merged
Conversation
michaelnebelforce-pushed
the
csharp/diableuselessassignment
branch
from
July 15, 2026 07:16
20c3ea4 to
cb3f8a8Comparecs/useless-assignment-to-local to medium.cs/useless-assignment-to-local from the code-quality suite.michaelnebel
marked this pull request as ready for review
July 15, 2026 07:53
Contributor
There was a problem hiding this comment.
Pull request overview
Removes cs/useless-assignment-to-local from C#’s standard code-quality suite while retaining it in the extended suite.
Changes:
- Excludes the query from the standard suite.
- Updates integration-test expectations and release notes.
Show a summary per file
| File | Description |
|---|---|
csharp/ql/src/codeql-suites/csharp-code-quality.qls | Excludes the query by ID. |
csharp/ql/src/change-notes/2026-07-15-code-quality-useless-assignment.md | Documents the suite change. |
csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected | Updates expected suite contents. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Medium
jketema
approved these changes
Jul 15, 2026
Uh oh!
There was an error while loading. Please reload this page.
hvitved
commented
Aug 3, 2026
Contributor
Too many FPs? |
jketema
commented
Aug 3, 2026
Contributor
Correct. |
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we remove the query
cs/useless-assignment-to-localfrom thecode-qualitysuite.