Uh oh!
There was an error while loading. Please reload this page.
C++: Add flow sources for winreg.h - #22242
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds C++ data-flow source models for Windows Registry query APIs.
Changes:
- Models six ANSI/Wide registry query functions.
- Adds source and dereference-flow tests.
- Updates generated test expectations.
Show a summary per file
| File | Description |
|---|---|
cpp/ql/lib/ext/Windows.model.yml | Adds registry source models. |
cpp/ql/test/library-tests/dataflow/external-models/windows.cpp | Adds registry query tests. |
cpp/ql/test/library-tests/dataflow/external-models/sources.expected | Updates source expectations. |
cpp/ql/test/library-tests/dataflow/external-models/flow.expected | Updates flow expectations. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Medium
Uh oh!
There was an error while loading. Please reload this page.
MathiasVP
commented
Jul 28, 2026
ContributorAuthor
4 new results that look genuine 🎉 Merging! |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty simple stuff: I noticed that we don't model flow sources for various windows registry reads from winreg.h.
There's a TODO we can't resolve until Tom gets back from so we can get #22145 merged, after which I can finish my PR which adds support for access paths at sources in MaD.