Uh oh!
There was an error while loading. Please reload this page.
Ruby: add qltest documenting implicit return dataflow gaps - #22272
Merged
aschackmull merged 2 commits intoAug 4, 2026
Conversation
Documents existing behavior for implicit returns (no return keyword) from: - method body with ensure present - rescue clause (with and without ensure) - else clause (with and without ensure) The test shows that only simple body returns currently work; all other cases are marked MISSING to document the known gaps.
CopilotAI
changed the title
Ruby: add qltest for implicit return stepsRuby: add qltest documenting implicit return dataflow gapsAug 3, 2026
Copilotcreated this pull request from a session on behalf of aschackmullAugust 3, 2026 12:59 View session
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a focused Ruby data-flow regression test documenting known implicit-return gaps.
Changes:
- Covers method body,
rescue, andelseimplicit returns with optionalensure. - Marks known missing flows without failing the test.
Show a summary per file
| File | Description |
|---|---|
implicit-return.ql | Defines the path query. |
implicit-return.expected | Records current results. |
implicit_return.rb | Provides inline flow cases and expectations. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+3
to
+4
| # An implicit return is when no `return` statement is used; instead the | ||
| # last evaluated expression is returned. |
hvitved
approved these changes
Aug 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
aschackmull
deleted the
copilot/add-qltest-documenting-existing-behavior
branch
August 4, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby's dataflow
ExprReturnNodeonly recognises implicit returns that are direct statements of the method body (c.getBody().getAStmt()), missing cases where the returned value is in arescue,else, or a body withensurepresent.New test:
implicit-returnSix cases, all using implicit returns (no
returnkeyword):MISSING:annotations document known gaps without causing test failures; the framework will emit "Fixed missing result" when the bug is eventually addressed.