Uh oh!
There was an error while loading. Please reload this page.
Actions: Remove experimental self-hosted runner query - #22274
Merged
aschackmull merged 1 commit intoAug 4, 2026
Conversation
Runner labels cannot reliably distinguish self-hosted runners from managed runners. Deprecate the supporting SelfHostedQuery library module.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unreliable experimental self-hosted runner query while preserving and deprecating its public library module.
Changes:
- Removed the experimental query and its test fixtures/results.
- Deprecated
SelfHostedQuerywith an explanatory change note. - Updated query-suite expectations.
Show a summary per file
| File | Description |
|---|---|
actions/ql/test/query-tests/Security/CWE-284/CodeExecutionOnSelfHostedRunner.qlref | Removes the obsolete query reference. |
actions/ql/test/query-tests/Security/CWE-284/CodeExecutionOnSelfHostedRunner.expected | Removes obsolete expected results. |
actions/ql/test/query-tests/Security/CWE-284/.github/workflows/test3.yml | Removes a managed-runner fixture. |
actions/ql/test/query-tests/Security/CWE-284/.github/workflows/test2.yml | Removes a self-hosted-runner fixture. |
actions/ql/test/query-tests/Security/CWE-284/.github/workflows/test1.yml | Removes the primary query fixture. |
actions/ql/src/experimental/Security/CWE-284/CodeExecutionOnSelfHostedRunner.ql | Deletes the experimental query. |
actions/ql/lib/codeql/actions/security/SelfHostedQuery.qll | Marks the library module deprecated. |
actions/ql/lib/change-notes/2026-08-03-deprecate-self-hosted-query.md | Documents the deprecation. |
actions/ql/integration-tests/query-suite/not_included_in_qls.expected | Removes the deleted query from expected output. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Balanced
aschackmull
approved these changes
Aug 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
JarLob
commented
Aug 4, 2026
ContributorAuthor
Just a check, what do you think about |
aschackmull
commented
Aug 4, 2026
Contributor
It's probably fine. You could possibly also delete the library if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runner labels cannot reliably distinguish self-hosted runners from managed runners. Deprecate the supporting SelfHostedQuery library module.
Deleting the query because it is experimental. But the library is not, so deprecating it. Let me know if it is better delete both or deprecate both.