Rust: Change canonical paths for trait items - #22376

Merged
hvitved merged 4 commits into
mainfrom
hvitved-rust-canonical-paths
Aug 20, 2026
Merged

Rust: Change canonical paths for trait items#22376
hvitved merged 4 commits into
mainfrom
hvitved-rust-canonical-paths

Conversation

@hvitved

@hvitvedhvitved commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
  • update Rust library models, tests, generated expectations, and documentation to the new format
  • add a change note for custom data extension model authors

Testing

  • regenerated affected Rust CodeQL test expectations with codeql test run --learn
  • all 38 affected tests passed

hvitvedand others added 3 commits August 19, 2026 09:42
@hvitved
Rust: Change canonical paths for trait items
8a9ef4c
Use `crate::Trait::foo` instead of `<_ as crate::Trait>::foo` for trait items.
@hvitved
Rust: Update trait item canonical path references
2a7c932
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@hvitved
Rust: Document trait item canonical path change
f902541
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@github-actionsgithub-actionsBot added documentation Rust Pull requests that update Rust code labels Aug 19, 2026
@hvitved
hvitved requested a balanced review from CopilotAugust 19, 2026 08:31
CopilotAI reviewed Aug 19, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Changes Rust trait-item canonical paths to the simpler Trait::item format and migrates affected models, documentation, and generated expectations.

Changes:

  • Updates canonical-path generation for trait items.
  • Migrates Rust library and test models to the new format.
  • Updates documentation, change notes, and generated expectations.
Show a summary per file
FileDescription
rust/ql/test/query-tests/security/CWE-918/RequestForgery.expectedRegenerates request-forgery expectations.
rust/ql/test/query-tests/security/CWE-798/HardcodedCryptographicValue.expectedRegenerates cryptographic-value expectations.
rust/ql/test/query-tests/security/CWE-770/UncontrolledAllocationSize.expectedRegenerates allocation-size expectations.
rust/ql/test/query-tests/security/CWE-312/CleartextLogging.expectedRegenerates logging expectations.
rust/ql/test/query-tests/security/CWE-117/LogInjection.expectedRegenerates log-injection expectations.
rust/ql/test/query-tests/security/CWE-079/warp/XSS.expectedRegenerates Warp XSS expectations.
rust/ql/test/query-tests/security/CWE-022/TaintedPath.expectedRegenerates tainted-path expectations.
rust/ql/test/library-tests/dataflow/strings/inline-taint-flow.expectedUpdates string data-flow expectations.
rust/ql/test/library-tests/dataflow/sources/web_frameworks/InlineFlow.expectedUpdates web-framework model expectations.
rust/ql/test/library-tests/dataflow/sources/env/InlineFlow.expectedUpdates environment-source expectations.
rust/ql/test/library-tests/dataflow/sources/database/InlineFlow.expectedUpdates database-source expectations.
rust/ql/test/library-tests/dataflow/models/models.ext.ymlMigrates test extension models.
rust/ql/test/library-tests/dataflow/models/models.expectedRegenerates model expectations.
rust/ql/test/library-tests/dataflow/modeled/inline-flow.expectedUpdates modeled-flow expectations.
rust/ql/test/library-tests/dataflow/local/inline-flow.expectedUpdates local-flow expectations.
rust/ql/test/library-tests/dataflow/global/inline-flow.expectedUpdates global-flow expectations.
rust/ql/test/library-tests/dataflow/collections/inline-flow.expectedUpdates collection-flow expectations.
rust/ql/test/extractor-tests/canonical_path/canonical_paths.expectedVerifies new extracted canonical paths.
rust/ql/lib/codeql/rust/internal/PathResolution.qllImplements the new trait-item path format.
rust/ql/lib/codeql/rust/frameworks/warp.model.ymlMigrates Warp trait models.
rust/ql/lib/codeql/rust/frameworks/tokio/io.model.ymlMigrates Tokio I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/io.model.ymlMigrates standard I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.ymlMigrates core trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.ymlMigrates allocation trait models.
rust/ql/lib/codeql/rust/frameworks/sqlx.model.ymlMigrates SQLx trait models.
rust/ql/lib/codeql/rust/frameworks/rustcrypto/rustcrypto.model.ymlMigrates RustCrypto trait models.
rust/ql/lib/codeql/rust/frameworks/mysql.model.ymlMigrates MySQL trait models.
rust/ql/lib/codeql/rust/frameworks/mysql-async.model.ymlMigrates asynchronous MySQL models.
rust/ql/lib/codeql/rust/frameworks/futures.model.ymlMigrates Futures I/O models.
rust/ql/lib/codeql/rust/frameworks/asyncstd/io.model.ymlMigrates async-std I/O models.
rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qllUpdates an internal path reference.
rust/ql/lib/change-notes/2026-08-19-trait-canonical-paths.mdDocuments the model migration.
docs/codeql/codeql-language-guides/customizing-library-models-for-rust.rstDocuments the new canonical-path syntax.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 39/39 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment threadrust/ql/lib/codeql/rust/frameworks/tokio/io.model.yml Outdated
@hvitved
Potential fix for pull request finding
4f48b45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hvitved
hvitved marked this pull request as ready for review August 19, 2026 12:15
@hvitved
hvitved requested review from a team as code ownersAugust 19, 2026 12:15
@hvitved
hvitved requested a review from redsun82August 19, 2026 18:04
@hvitvedhvitved mentioned this pull request Aug 20, 2026
Merged
@geoffw0

geoffw0 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item

This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?

@hvitved

hvitved commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?

I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.

@redsun82

redsun82 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?

I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.

yep, that's my understanding as well.

@hvitved
hvitved merged commit 79d40e6 into mainAug 20, 2026
22 checks passed
@hvitved
hvitved deleted the hvitved-rust-canonical-paths branch August 20, 2026 12:50
@geoffw0

geoffw0 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Thanks. 👍

@hvitvedhvitved mentioned this pull request Aug 28, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@redsun82redsun82redsun82 approved these changes

Assignees

No one assigned

Labels

documentationRustPull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hvitved@geoffw0@redsun82
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Rust: Change canonical paths for trait items - #22376
Merged
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Aug 20, 2026
Merged
Rust: Change canonical paths for trait items#22376
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Conversation
@hvitved
@hvitvedhvitved
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Summary
  • use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
  • update Rust library models, tests, generated expectations, and documentation to the new format
  • add a change note for custom data extension model authors
Testing
  • regenerated affected Rust CodeQL test expectations with codeql test run --learn
  • all 38 affected tests passed
hvitvedand others
added 3 commits
August 19, 2026 09:42
@hvitved
Rust: Change canonical paths for trait items
8a9ef4c
Use `crate::Trait::foo` instead of `<_ as crate::Trait>::foo` for trait items.
@hvitved
Rust: Update trait item canonical path references
2a7c932
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@hvitved
Rust: Document trait item canonical path change
f902541
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@github-actionsgithub-actionsBot
added

documentation

Rust
Pull requests that update Rust code
labels
Aug 19, 2026
@hvitved
hvitved
requested a balanced review from CopilotAugust 19, 2026 08:31
CopilotAI
reviewed
Aug 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Changes Rust trait-item canonical paths to the simpler Trait::item format and migrates affected models, documentation, and generated expectations.
Changes:
  • Updates canonical-path generation for trait items.
  • Migrates Rust library and test models to the new format.
  • Updates documentation, change notes, and generated expectations.
Show a summary per file
FileDescription
rust/ql/test/query-tests/security/CWE-918/RequestForgery.expectedRegenerates request-forgery expectations.
rust/ql/test/query-tests/security/CWE-798/HardcodedCryptographicValue.expectedRegenerates cryptographic-value expectations.
rust/ql/test/query-tests/security/CWE-770/UncontrolledAllocationSize.expectedRegenerates allocation-size expectations.
rust/ql/test/query-tests/security/CWE-312/CleartextLogging.expectedRegenerates logging expectations.
rust/ql/test/query-tests/security/CWE-117/LogInjection.expectedRegenerates log-injection expectations.
rust/ql/test/query-tests/security/CWE-079/warp/XSS.expectedRegenerates Warp XSS expectations.
rust/ql/test/query-tests/security/CWE-022/TaintedPath.expectedRegenerates tainted-path expectations.
rust/ql/test/library-tests/dataflow/strings/inline-taint-flow.expectedUpdates string data-flow expectations.
rust/ql/test/library-tests/dataflow/sources/web_frameworks/InlineFlow.expectedUpdates web-framework model expectations.
rust/ql/test/library-tests/dataflow/sources/env/InlineFlow.expectedUpdates environment-source expectations.
rust/ql/test/library-tests/dataflow/sources/database/InlineFlow.expectedUpdates database-source expectations.
rust/ql/test/library-tests/dataflow/models/models.ext.ymlMigrates test extension models.
rust/ql/test/library-tests/dataflow/models/models.expectedRegenerates model expectations.
rust/ql/test/library-tests/dataflow/modeled/inline-flow.expectedUpdates modeled-flow expectations.
rust/ql/test/library-tests/dataflow/local/inline-flow.expectedUpdates local-flow expectations.
rust/ql/test/library-tests/dataflow/global/inline-flow.expectedUpdates global-flow expectations.
rust/ql/test/library-tests/dataflow/collections/inline-flow.expectedUpdates collection-flow expectations.
rust/ql/test/extractor-tests/canonical_path/canonical_paths.expectedVerifies new extracted canonical paths.
rust/ql/lib/codeql/rust/internal/PathResolution.qllImplements the new trait-item path format.
rust/ql/lib/codeql/rust/frameworks/warp.model.ymlMigrates Warp trait models.
rust/ql/lib/codeql/rust/frameworks/tokio/io.model.ymlMigrates Tokio I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/io.model.ymlMigrates standard I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.ymlMigrates core trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.ymlMigrates allocation trait models.
rust/ql/lib/codeql/rust/frameworks/sqlx.model.ymlMigrates SQLx trait models.
rust/ql/lib/codeql/rust/frameworks/rustcrypto/rustcrypto.model.ymlMigrates RustCrypto trait models.
rust/ql/lib/codeql/rust/frameworks/mysql.model.ymlMigrates MySQL trait models.
rust/ql/lib/codeql/rust/frameworks/mysql-async.model.ymlMigrates asynchronous MySQL models.
rust/ql/lib/codeql/rust/frameworks/futures.model.ymlMigrates Futures I/O models.
rust/ql/lib/codeql/rust/frameworks/asyncstd/io.model.ymlMigrates async-std I/O models.
rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qllUpdates an internal path reference.
rust/ql/lib/change-notes/2026-08-19-trait-canonical-paths.mdDocuments the model migration.
docs/codeql/codeql-language-guides/customizing-library-models-for-rust.rstDocuments the new canonical-path syntax.
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
  • Files reviewed: 39/39 changed files
  • Comments generated: 1
  • Review effort level: Balanced
Comment threadrust/ql/lib/codeql/rust/frameworks/tokio/io.model.yml
Outdated

@hvitved
Potential fix for pull request finding
4f48b45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hvitved
hvitved
marked this pull request as ready for review
August 19, 2026 12:15
@hvitved
hvitved
requested review from
a team
as code ownersAugust 19, 2026 12:15
@hvitved
hvitved
requested a review
from redsun82August 19, 2026 18:04
@hvitvedhvitved
mentioned this pull request
Aug 20, 2026
 Merged

@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
@hvitved
hvitved
commented
Aug 20, 2026

Copy link


Copy Markdown

ContributorAuthor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
@redsun82
redsun82
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
yep, that's my understanding as well.
@hvitved
hvitved
merged commit 79d40e6
into
mainAug 20, 2026

22 checks passed

@hvitved
hvitved
deleted the

hvitved-rust-canonical-paths

branch
August 20, 2026 12:50
@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Thanks. 👍
@hvitvedhvitved
mentioned this pull request
Aug 28, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@redsun82redsun82redsun82 approved these changes

Assignees


No one assigned


Labels

documentationRustPull requests that update Rust code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hvitved@geoffw0@redsun82

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rust: Change canonical paths for trait items - #22376
Merged
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Aug 20, 2026
Merged
Rust: Change canonical paths for trait items#22376
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Conversation
@hvitved
@hvitvedhvitved
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Summary
  • use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
  • update Rust library models, tests, generated expectations, and documentation to the new format
  • add a change note for custom data extension model authors
Testing
  • regenerated affected Rust CodeQL test expectations with codeql test run --learn
  • all 38 affected tests passed
hvitvedand others
added 3 commits
August 19, 2026 09:42
@hvitved
Rust: Change canonical paths for trait items
8a9ef4c
Use `crate::Trait::foo` instead of `<_ as crate::Trait>::foo` for trait items.
@hvitved
Rust: Update trait item canonical path references
2a7c932
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@hvitved
Rust: Document trait item canonical path change
f902541
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@github-actionsgithub-actionsBot
added

documentation

Rust
Pull requests that update Rust code
labels
Aug 19, 2026
@hvitved
hvitved
requested a balanced review from CopilotAugust 19, 2026 08:31
CopilotAI
reviewed
Aug 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Changes Rust trait-item canonical paths to the simpler Trait::item format and migrates affected models, documentation, and generated expectations.
Changes:
  • Updates canonical-path generation for trait items.
  • Migrates Rust library and test models to the new format.
  • Updates documentation, change notes, and generated expectations.
Show a summary per file
FileDescription
rust/ql/test/query-tests/security/CWE-918/RequestForgery.expectedRegenerates request-forgery expectations.
rust/ql/test/query-tests/security/CWE-798/HardcodedCryptographicValue.expectedRegenerates cryptographic-value expectations.
rust/ql/test/query-tests/security/CWE-770/UncontrolledAllocationSize.expectedRegenerates allocation-size expectations.
rust/ql/test/query-tests/security/CWE-312/CleartextLogging.expectedRegenerates logging expectations.
rust/ql/test/query-tests/security/CWE-117/LogInjection.expectedRegenerates log-injection expectations.
rust/ql/test/query-tests/security/CWE-079/warp/XSS.expectedRegenerates Warp XSS expectations.
rust/ql/test/query-tests/security/CWE-022/TaintedPath.expectedRegenerates tainted-path expectations.
rust/ql/test/library-tests/dataflow/strings/inline-taint-flow.expectedUpdates string data-flow expectations.
rust/ql/test/library-tests/dataflow/sources/web_frameworks/InlineFlow.expectedUpdates web-framework model expectations.
rust/ql/test/library-tests/dataflow/sources/env/InlineFlow.expectedUpdates environment-source expectations.
rust/ql/test/library-tests/dataflow/sources/database/InlineFlow.expectedUpdates database-source expectations.
rust/ql/test/library-tests/dataflow/models/models.ext.ymlMigrates test extension models.
rust/ql/test/library-tests/dataflow/models/models.expectedRegenerates model expectations.
rust/ql/test/library-tests/dataflow/modeled/inline-flow.expectedUpdates modeled-flow expectations.
rust/ql/test/library-tests/dataflow/local/inline-flow.expectedUpdates local-flow expectations.
rust/ql/test/library-tests/dataflow/global/inline-flow.expectedUpdates global-flow expectations.
rust/ql/test/library-tests/dataflow/collections/inline-flow.expectedUpdates collection-flow expectations.
rust/ql/test/extractor-tests/canonical_path/canonical_paths.expectedVerifies new extracted canonical paths.
rust/ql/lib/codeql/rust/internal/PathResolution.qllImplements the new trait-item path format.
rust/ql/lib/codeql/rust/frameworks/warp.model.ymlMigrates Warp trait models.
rust/ql/lib/codeql/rust/frameworks/tokio/io.model.ymlMigrates Tokio I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/io.model.ymlMigrates standard I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.ymlMigrates core trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.ymlMigrates allocation trait models.
rust/ql/lib/codeql/rust/frameworks/sqlx.model.ymlMigrates SQLx trait models.
rust/ql/lib/codeql/rust/frameworks/rustcrypto/rustcrypto.model.ymlMigrates RustCrypto trait models.
rust/ql/lib/codeql/rust/frameworks/mysql.model.ymlMigrates MySQL trait models.
rust/ql/lib/codeql/rust/frameworks/mysql-async.model.ymlMigrates asynchronous MySQL models.
rust/ql/lib/codeql/rust/frameworks/futures.model.ymlMigrates Futures I/O models.
rust/ql/lib/codeql/rust/frameworks/asyncstd/io.model.ymlMigrates async-std I/O models.
rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qllUpdates an internal path reference.
rust/ql/lib/change-notes/2026-08-19-trait-canonical-paths.mdDocuments the model migration.
docs/codeql/codeql-language-guides/customizing-library-models-for-rust.rstDocuments the new canonical-path syntax.
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
  • Files reviewed: 39/39 changed files
  • Comments generated: 1
  • Review effort level: Balanced
Comment threadrust/ql/lib/codeql/rust/frameworks/tokio/io.model.yml
Outdated

@hvitved
Potential fix for pull request finding
4f48b45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hvitved
hvitved
marked this pull request as ready for review
August 19, 2026 12:15
@hvitved
hvitved
requested review from
a team
as code ownersAugust 19, 2026 12:15
@hvitved
hvitved
requested a review
from redsun82August 19, 2026 18:04
@hvitvedhvitved
mentioned this pull request
Aug 20, 2026
 Merged

@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
@hvitved
hvitved
commented
Aug 20, 2026

Copy link


Copy Markdown

ContributorAuthor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
@redsun82
redsun82
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
yep, that's my understanding as well.
@hvitved
hvitved
merged commit 79d40e6
into
mainAug 20, 2026

22 checks passed

@hvitved
hvitved
deleted the

hvitved-rust-canonical-paths

branch
August 20, 2026 12:50
@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Thanks. 👍
@hvitvedhvitved
mentioned this pull request
Aug 28, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@redsun82redsun82redsun82 approved these changes

Assignees


No one assigned


Labels

documentationRustPull requests that update Rust code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hvitved@geoffw0@redsun82

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rust: Change canonical paths for trait items - #22376
Merged
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Aug 20, 2026
Merged
Rust: Change canonical paths for trait items#22376
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Conversation
@hvitved
@hvitvedhvitved
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Summary
  • use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
  • update Rust library models, tests, generated expectations, and documentation to the new format
  • add a change note for custom data extension model authors
Testing
  • regenerated affected Rust CodeQL test expectations with codeql test run --learn
  • all 38 affected tests passed
hvitvedand others
added 3 commits
August 19, 2026 09:42
@hvitved
Rust: Change canonical paths for trait items
8a9ef4c
Use `crate::Trait::foo` instead of `<_ as crate::Trait>::foo` for trait items.
@hvitved
Rust: Update trait item canonical path references
2a7c932
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@hvitved
Rust: Document trait item canonical path change
f902541
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@github-actionsgithub-actionsBot
added

documentation

Rust
Pull requests that update Rust code
labels
Aug 19, 2026
@hvitved
hvitved
requested a balanced review from CopilotAugust 19, 2026 08:31
CopilotAI
reviewed
Aug 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Changes Rust trait-item canonical paths to the simpler Trait::item format and migrates affected models, documentation, and generated expectations.
Changes:
  • Updates canonical-path generation for trait items.
  • Migrates Rust library and test models to the new format.
  • Updates documentation, change notes, and generated expectations.
Show a summary per file
FileDescription
rust/ql/test/query-tests/security/CWE-918/RequestForgery.expectedRegenerates request-forgery expectations.
rust/ql/test/query-tests/security/CWE-798/HardcodedCryptographicValue.expectedRegenerates cryptographic-value expectations.
rust/ql/test/query-tests/security/CWE-770/UncontrolledAllocationSize.expectedRegenerates allocation-size expectations.
rust/ql/test/query-tests/security/CWE-312/CleartextLogging.expectedRegenerates logging expectations.
rust/ql/test/query-tests/security/CWE-117/LogInjection.expectedRegenerates log-injection expectations.
rust/ql/test/query-tests/security/CWE-079/warp/XSS.expectedRegenerates Warp XSS expectations.
rust/ql/test/query-tests/security/CWE-022/TaintedPath.expectedRegenerates tainted-path expectations.
rust/ql/test/library-tests/dataflow/strings/inline-taint-flow.expectedUpdates string data-flow expectations.
rust/ql/test/library-tests/dataflow/sources/web_frameworks/InlineFlow.expectedUpdates web-framework model expectations.
rust/ql/test/library-tests/dataflow/sources/env/InlineFlow.expectedUpdates environment-source expectations.
rust/ql/test/library-tests/dataflow/sources/database/InlineFlow.expectedUpdates database-source expectations.
rust/ql/test/library-tests/dataflow/models/models.ext.ymlMigrates test extension models.
rust/ql/test/library-tests/dataflow/models/models.expectedRegenerates model expectations.
rust/ql/test/library-tests/dataflow/modeled/inline-flow.expectedUpdates modeled-flow expectations.
rust/ql/test/library-tests/dataflow/local/inline-flow.expectedUpdates local-flow expectations.
rust/ql/test/library-tests/dataflow/global/inline-flow.expectedUpdates global-flow expectations.
rust/ql/test/library-tests/dataflow/collections/inline-flow.expectedUpdates collection-flow expectations.
rust/ql/test/extractor-tests/canonical_path/canonical_paths.expectedVerifies new extracted canonical paths.
rust/ql/lib/codeql/rust/internal/PathResolution.qllImplements the new trait-item path format.
rust/ql/lib/codeql/rust/frameworks/warp.model.ymlMigrates Warp trait models.
rust/ql/lib/codeql/rust/frameworks/tokio/io.model.ymlMigrates Tokio I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/io.model.ymlMigrates standard I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.ymlMigrates core trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.ymlMigrates allocation trait models.
rust/ql/lib/codeql/rust/frameworks/sqlx.model.ymlMigrates SQLx trait models.
rust/ql/lib/codeql/rust/frameworks/rustcrypto/rustcrypto.model.ymlMigrates RustCrypto trait models.
rust/ql/lib/codeql/rust/frameworks/mysql.model.ymlMigrates MySQL trait models.
rust/ql/lib/codeql/rust/frameworks/mysql-async.model.ymlMigrates asynchronous MySQL models.
rust/ql/lib/codeql/rust/frameworks/futures.model.ymlMigrates Futures I/O models.
rust/ql/lib/codeql/rust/frameworks/asyncstd/io.model.ymlMigrates async-std I/O models.
rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qllUpdates an internal path reference.
rust/ql/lib/change-notes/2026-08-19-trait-canonical-paths.mdDocuments the model migration.
docs/codeql/codeql-language-guides/customizing-library-models-for-rust.rstDocuments the new canonical-path syntax.
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
  • Files reviewed: 39/39 changed files
  • Comments generated: 1
  • Review effort level: Balanced
Comment threadrust/ql/lib/codeql/rust/frameworks/tokio/io.model.yml
Outdated

@hvitved
Potential fix for pull request finding
4f48b45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hvitved
hvitved
marked this pull request as ready for review
August 19, 2026 12:15
@hvitved
hvitved
requested review from
a team
as code ownersAugust 19, 2026 12:15
@hvitved
hvitved
requested a review
from redsun82August 19, 2026 18:04
@hvitvedhvitved
mentioned this pull request
Aug 20, 2026
 Merged

@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
@hvitved
hvitved
commented
Aug 20, 2026

Copy link


Copy Markdown

ContributorAuthor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
@redsun82
redsun82
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
yep, that's my understanding as well.
@hvitved
hvitved
merged commit 79d40e6
into
mainAug 20, 2026

22 checks passed

@hvitved
hvitved
deleted the

hvitved-rust-canonical-paths

branch
August 20, 2026 12:50
@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Thanks. 👍
@hvitvedhvitved
mentioned this pull request
Aug 28, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@redsun82redsun82redsun82 approved these changes

Assignees


No one assigned


Labels

documentationRustPull requests that update Rust code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hvitved@geoffw0@redsun82

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Rust: Change canonical paths for trait items - #22376
Merged
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Aug 20, 2026
Merged
Rust: Change canonical paths for trait items#22376
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Conversation
@hvitved
@hvitvedhvitved
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Summary
  • use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
  • update Rust library models, tests, generated expectations, and documentation to the new format
  • add a change note for custom data extension model authors
Testing
  • regenerated affected Rust CodeQL test expectations with codeql test run --learn
  • all 38 affected tests passed
hvitvedand others
added 3 commits
August 19, 2026 09:42
@hvitved
Rust: Change canonical paths for trait items
8a9ef4c
Use `crate::Trait::foo` instead of `<_ as crate::Trait>::foo` for trait items.
@hvitved
Rust: Update trait item canonical path references
2a7c932
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@hvitved
Rust: Document trait item canonical path change
f902541
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@github-actionsgithub-actionsBot
added

documentation

Rust
Pull requests that update Rust code
labels
Aug 19, 2026
@hvitved
hvitved
requested a balanced review from CopilotAugust 19, 2026 08:31
CopilotAI
reviewed
Aug 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Changes Rust trait-item canonical paths to the simpler Trait::item format and migrates affected models, documentation, and generated expectations.
Changes:
  • Updates canonical-path generation for trait items.
  • Migrates Rust library and test models to the new format.
  • Updates documentation, change notes, and generated expectations.
Show a summary per file
FileDescription
rust/ql/test/query-tests/security/CWE-918/RequestForgery.expectedRegenerates request-forgery expectations.
rust/ql/test/query-tests/security/CWE-798/HardcodedCryptographicValue.expectedRegenerates cryptographic-value expectations.
rust/ql/test/query-tests/security/CWE-770/UncontrolledAllocationSize.expectedRegenerates allocation-size expectations.
rust/ql/test/query-tests/security/CWE-312/CleartextLogging.expectedRegenerates logging expectations.
rust/ql/test/query-tests/security/CWE-117/LogInjection.expectedRegenerates log-injection expectations.
rust/ql/test/query-tests/security/CWE-079/warp/XSS.expectedRegenerates Warp XSS expectations.
rust/ql/test/query-tests/security/CWE-022/TaintedPath.expectedRegenerates tainted-path expectations.
rust/ql/test/library-tests/dataflow/strings/inline-taint-flow.expectedUpdates string data-flow expectations.
rust/ql/test/library-tests/dataflow/sources/web_frameworks/InlineFlow.expectedUpdates web-framework model expectations.
rust/ql/test/library-tests/dataflow/sources/env/InlineFlow.expectedUpdates environment-source expectations.
rust/ql/test/library-tests/dataflow/sources/database/InlineFlow.expectedUpdates database-source expectations.
rust/ql/test/library-tests/dataflow/models/models.ext.ymlMigrates test extension models.
rust/ql/test/library-tests/dataflow/models/models.expectedRegenerates model expectations.
rust/ql/test/library-tests/dataflow/modeled/inline-flow.expectedUpdates modeled-flow expectations.
rust/ql/test/library-tests/dataflow/local/inline-flow.expectedUpdates local-flow expectations.
rust/ql/test/library-tests/dataflow/global/inline-flow.expectedUpdates global-flow expectations.
rust/ql/test/library-tests/dataflow/collections/inline-flow.expectedUpdates collection-flow expectations.
rust/ql/test/extractor-tests/canonical_path/canonical_paths.expectedVerifies new extracted canonical paths.
rust/ql/lib/codeql/rust/internal/PathResolution.qllImplements the new trait-item path format.
rust/ql/lib/codeql/rust/frameworks/warp.model.ymlMigrates Warp trait models.
rust/ql/lib/codeql/rust/frameworks/tokio/io.model.ymlMigrates Tokio I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/io.model.ymlMigrates standard I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.ymlMigrates core trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.ymlMigrates allocation trait models.
rust/ql/lib/codeql/rust/frameworks/sqlx.model.ymlMigrates SQLx trait models.
rust/ql/lib/codeql/rust/frameworks/rustcrypto/rustcrypto.model.ymlMigrates RustCrypto trait models.
rust/ql/lib/codeql/rust/frameworks/mysql.model.ymlMigrates MySQL trait models.
rust/ql/lib/codeql/rust/frameworks/mysql-async.model.ymlMigrates asynchronous MySQL models.
rust/ql/lib/codeql/rust/frameworks/futures.model.ymlMigrates Futures I/O models.
rust/ql/lib/codeql/rust/frameworks/asyncstd/io.model.ymlMigrates async-std I/O models.
rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qllUpdates an internal path reference.
rust/ql/lib/change-notes/2026-08-19-trait-canonical-paths.mdDocuments the model migration.
docs/codeql/codeql-language-guides/customizing-library-models-for-rust.rstDocuments the new canonical-path syntax.
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
  • Files reviewed: 39/39 changed files
  • Comments generated: 1
  • Review effort level: Balanced
Comment threadrust/ql/lib/codeql/rust/frameworks/tokio/io.model.yml
Outdated

@hvitved
Potential fix for pull request finding
4f48b45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hvitved
hvitved
marked this pull request as ready for review
August 19, 2026 12:15
@hvitved
hvitved
requested review from
a team
as code ownersAugust 19, 2026 12:15
@hvitved
hvitved
requested a review
from redsun82August 19, 2026 18:04
@hvitvedhvitved
mentioned this pull request
Aug 20, 2026
 Merged

@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
@hvitved
hvitved
commented
Aug 20, 2026

Copy link


Copy Markdown

ContributorAuthor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
@redsun82
redsun82
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
yep, that's my understanding as well.
@hvitved
hvitved
merged commit 79d40e6
into
mainAug 20, 2026

22 checks passed

@hvitved
hvitved
deleted the

hvitved-rust-canonical-paths

branch
August 20, 2026 12:50
@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Thanks. 👍
@hvitvedhvitved
mentioned this pull request
Aug 28, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@redsun82redsun82redsun82 approved these changes

Assignees


No one assigned


Labels

documentationRustPull requests that update Rust code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hvitved@geoffw0@redsun82

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rust: Change canonical paths for trait items - #22376
Merged
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Aug 20, 2026
Merged
Rust: Change canonical paths for trait items#22376
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Conversation
@hvitved
@hvitvedhvitved
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Summary
  • use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
  • update Rust library models, tests, generated expectations, and documentation to the new format
  • add a change note for custom data extension model authors
Testing
  • regenerated affected Rust CodeQL test expectations with codeql test run --learn
  • all 38 affected tests passed
hvitvedand others
added 3 commits
August 19, 2026 09:42
@hvitved
Rust: Change canonical paths for trait items
8a9ef4c
Use `crate::Trait::foo` instead of `<_ as crate::Trait>::foo` for trait items.
@hvitved
Rust: Update trait item canonical path references
2a7c932
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@hvitved
Rust: Document trait item canonical path change
f902541
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@github-actionsgithub-actionsBot
added

documentation

Rust
Pull requests that update Rust code
labels
Aug 19, 2026
@hvitved
hvitved
requested a balanced review from CopilotAugust 19, 2026 08:31
CopilotAI
reviewed
Aug 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Changes Rust trait-item canonical paths to the simpler Trait::item format and migrates affected models, documentation, and generated expectations.
Changes:
  • Updates canonical-path generation for trait items.
  • Migrates Rust library and test models to the new format.
  • Updates documentation, change notes, and generated expectations.
Show a summary per file
FileDescription
rust/ql/test/query-tests/security/CWE-918/RequestForgery.expectedRegenerates request-forgery expectations.
rust/ql/test/query-tests/security/CWE-798/HardcodedCryptographicValue.expectedRegenerates cryptographic-value expectations.
rust/ql/test/query-tests/security/CWE-770/UncontrolledAllocationSize.expectedRegenerates allocation-size expectations.
rust/ql/test/query-tests/security/CWE-312/CleartextLogging.expectedRegenerates logging expectations.
rust/ql/test/query-tests/security/CWE-117/LogInjection.expectedRegenerates log-injection expectations.
rust/ql/test/query-tests/security/CWE-079/warp/XSS.expectedRegenerates Warp XSS expectations.
rust/ql/test/query-tests/security/CWE-022/TaintedPath.expectedRegenerates tainted-path expectations.
rust/ql/test/library-tests/dataflow/strings/inline-taint-flow.expectedUpdates string data-flow expectations.
rust/ql/test/library-tests/dataflow/sources/web_frameworks/InlineFlow.expectedUpdates web-framework model expectations.
rust/ql/test/library-tests/dataflow/sources/env/InlineFlow.expectedUpdates environment-source expectations.
rust/ql/test/library-tests/dataflow/sources/database/InlineFlow.expectedUpdates database-source expectations.
rust/ql/test/library-tests/dataflow/models/models.ext.ymlMigrates test extension models.
rust/ql/test/library-tests/dataflow/models/models.expectedRegenerates model expectations.
rust/ql/test/library-tests/dataflow/modeled/inline-flow.expectedUpdates modeled-flow expectations.
rust/ql/test/library-tests/dataflow/local/inline-flow.expectedUpdates local-flow expectations.
rust/ql/test/library-tests/dataflow/global/inline-flow.expectedUpdates global-flow expectations.
rust/ql/test/library-tests/dataflow/collections/inline-flow.expectedUpdates collection-flow expectations.
rust/ql/test/extractor-tests/canonical_path/canonical_paths.expectedVerifies new extracted canonical paths.
rust/ql/lib/codeql/rust/internal/PathResolution.qllImplements the new trait-item path format.
rust/ql/lib/codeql/rust/frameworks/warp.model.ymlMigrates Warp trait models.
rust/ql/lib/codeql/rust/frameworks/tokio/io.model.ymlMigrates Tokio I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/io.model.ymlMigrates standard I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.ymlMigrates core trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.ymlMigrates allocation trait models.
rust/ql/lib/codeql/rust/frameworks/sqlx.model.ymlMigrates SQLx trait models.
rust/ql/lib/codeql/rust/frameworks/rustcrypto/rustcrypto.model.ymlMigrates RustCrypto trait models.
rust/ql/lib/codeql/rust/frameworks/mysql.model.ymlMigrates MySQL trait models.
rust/ql/lib/codeql/rust/frameworks/mysql-async.model.ymlMigrates asynchronous MySQL models.
rust/ql/lib/codeql/rust/frameworks/futures.model.ymlMigrates Futures I/O models.
rust/ql/lib/codeql/rust/frameworks/asyncstd/io.model.ymlMigrates async-std I/O models.
rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qllUpdates an internal path reference.
rust/ql/lib/change-notes/2026-08-19-trait-canonical-paths.mdDocuments the model migration.
docs/codeql/codeql-language-guides/customizing-library-models-for-rust.rstDocuments the new canonical-path syntax.
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
  • Files reviewed: 39/39 changed files
  • Comments generated: 1
  • Review effort level: Balanced
Comment threadrust/ql/lib/codeql/rust/frameworks/tokio/io.model.yml
Outdated

@hvitved
Potential fix for pull request finding
4f48b45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hvitved
hvitved
marked this pull request as ready for review
August 19, 2026 12:15
@hvitved
hvitved
requested review from
a team
as code ownersAugust 19, 2026 12:15
@hvitved
hvitved
requested a review
from redsun82August 19, 2026 18:04
@hvitvedhvitved
mentioned this pull request
Aug 20, 2026
 Merged

@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
@hvitved
hvitved
commented
Aug 20, 2026

Copy link


Copy Markdown

ContributorAuthor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
@redsun82
redsun82
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
yep, that's my understanding as well.
@hvitved
hvitved
merged commit 79d40e6
into
mainAug 20, 2026

22 checks passed

@hvitved
hvitved
deleted the

hvitved-rust-canonical-paths

branch
August 20, 2026 12:50
@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Thanks. 👍
@hvitvedhvitved
mentioned this pull request
Aug 28, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@redsun82redsun82redsun82 approved these changes

Assignees


No one assigned


Labels

documentationRustPull requests that update Rust code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hvitved@geoffw0@redsun82

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rust: Change canonical paths for trait items - #22376
Merged
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Aug 20, 2026
Merged
Rust: Change canonical paths for trait items#22376
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Conversation
@hvitved
@hvitvedhvitved
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Summary
  • use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
  • update Rust library models, tests, generated expectations, and documentation to the new format
  • add a change note for custom data extension model authors
Testing
  • regenerated affected Rust CodeQL test expectations with codeql test run --learn
  • all 38 affected tests passed
hvitvedand others
added 3 commits
August 19, 2026 09:42
@hvitved
Rust: Change canonical paths for trait items
8a9ef4c
Use `crate::Trait::foo` instead of `<_ as crate::Trait>::foo` for trait items.
@hvitved
Rust: Update trait item canonical path references
2a7c932
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@hvitved
Rust: Document trait item canonical path change
f902541
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@github-actionsgithub-actionsBot
added

documentation

Rust
Pull requests that update Rust code
labels
Aug 19, 2026
@hvitved
hvitved
requested a balanced review from CopilotAugust 19, 2026 08:31
CopilotAI
reviewed
Aug 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Changes Rust trait-item canonical paths to the simpler Trait::item format and migrates affected models, documentation, and generated expectations.
Changes:
  • Updates canonical-path generation for trait items.
  • Migrates Rust library and test models to the new format.
  • Updates documentation, change notes, and generated expectations.
Show a summary per file
FileDescription
rust/ql/test/query-tests/security/CWE-918/RequestForgery.expectedRegenerates request-forgery expectations.
rust/ql/test/query-tests/security/CWE-798/HardcodedCryptographicValue.expectedRegenerates cryptographic-value expectations.
rust/ql/test/query-tests/security/CWE-770/UncontrolledAllocationSize.expectedRegenerates allocation-size expectations.
rust/ql/test/query-tests/security/CWE-312/CleartextLogging.expectedRegenerates logging expectations.
rust/ql/test/query-tests/security/CWE-117/LogInjection.expectedRegenerates log-injection expectations.
rust/ql/test/query-tests/security/CWE-079/warp/XSS.expectedRegenerates Warp XSS expectations.
rust/ql/test/query-tests/security/CWE-022/TaintedPath.expectedRegenerates tainted-path expectations.
rust/ql/test/library-tests/dataflow/strings/inline-taint-flow.expectedUpdates string data-flow expectations.
rust/ql/test/library-tests/dataflow/sources/web_frameworks/InlineFlow.expectedUpdates web-framework model expectations.
rust/ql/test/library-tests/dataflow/sources/env/InlineFlow.expectedUpdates environment-source expectations.
rust/ql/test/library-tests/dataflow/sources/database/InlineFlow.expectedUpdates database-source expectations.
rust/ql/test/library-tests/dataflow/models/models.ext.ymlMigrates test extension models.
rust/ql/test/library-tests/dataflow/models/models.expectedRegenerates model expectations.
rust/ql/test/library-tests/dataflow/modeled/inline-flow.expectedUpdates modeled-flow expectations.
rust/ql/test/library-tests/dataflow/local/inline-flow.expectedUpdates local-flow expectations.
rust/ql/test/library-tests/dataflow/global/inline-flow.expectedUpdates global-flow expectations.
rust/ql/test/library-tests/dataflow/collections/inline-flow.expectedUpdates collection-flow expectations.
rust/ql/test/extractor-tests/canonical_path/canonical_paths.expectedVerifies new extracted canonical paths.
rust/ql/lib/codeql/rust/internal/PathResolution.qllImplements the new trait-item path format.
rust/ql/lib/codeql/rust/frameworks/warp.model.ymlMigrates Warp trait models.
rust/ql/lib/codeql/rust/frameworks/tokio/io.model.ymlMigrates Tokio I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/io.model.ymlMigrates standard I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.ymlMigrates core trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.ymlMigrates allocation trait models.
rust/ql/lib/codeql/rust/frameworks/sqlx.model.ymlMigrates SQLx trait models.
rust/ql/lib/codeql/rust/frameworks/rustcrypto/rustcrypto.model.ymlMigrates RustCrypto trait models.
rust/ql/lib/codeql/rust/frameworks/mysql.model.ymlMigrates MySQL trait models.
rust/ql/lib/codeql/rust/frameworks/mysql-async.model.ymlMigrates asynchronous MySQL models.
rust/ql/lib/codeql/rust/frameworks/futures.model.ymlMigrates Futures I/O models.
rust/ql/lib/codeql/rust/frameworks/asyncstd/io.model.ymlMigrates async-std I/O models.
rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qllUpdates an internal path reference.
rust/ql/lib/change-notes/2026-08-19-trait-canonical-paths.mdDocuments the model migration.
docs/codeql/codeql-language-guides/customizing-library-models-for-rust.rstDocuments the new canonical-path syntax.
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
  • Files reviewed: 39/39 changed files
  • Comments generated: 1
  • Review effort level: Balanced
Comment threadrust/ql/lib/codeql/rust/frameworks/tokio/io.model.yml
Outdated

@hvitved
Potential fix for pull request finding
4f48b45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hvitved
hvitved
marked this pull request as ready for review
August 19, 2026 12:15
@hvitved
hvitved
requested review from
a team
as code ownersAugust 19, 2026 12:15
@hvitved
hvitved
requested a review
from redsun82August 19, 2026 18:04
@hvitvedhvitved
mentioned this pull request
Aug 20, 2026
 Merged

@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
@hvitved
hvitved
commented
Aug 20, 2026

Copy link


Copy Markdown

ContributorAuthor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
@redsun82
redsun82
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
yep, that's my understanding as well.
@hvitved
hvitved
merged commit 79d40e6
into
mainAug 20, 2026

22 checks passed

@hvitved
hvitved
deleted the

hvitved-rust-canonical-paths

branch
August 20, 2026 12:50
@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Thanks. 👍
@hvitvedhvitved
mentioned this pull request
Aug 28, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@redsun82redsun82redsun82 approved these changes

Assignees


No one assigned


Labels

documentationRustPull requests that update Rust code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hvitved@geoffw0@redsun82

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Rust: Change canonical paths for trait items - #22376
Merged
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Aug 20, 2026
Merged
Rust: Change canonical paths for trait items#22376
hvitved merged 4 commits into
mainfrom 
hvitved-rust-canonical-paths
Conversation
@hvitved
@hvitvedhvitved
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Summary
  • use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
  • update Rust library models, tests, generated expectations, and documentation to the new format
  • add a change note for custom data extension model authors
Testing
  • regenerated affected Rust CodeQL test expectations with codeql test run --learn
  • all 38 affected tests passed
hvitvedand others
added 3 commits
August 19, 2026 09:42
@hvitved
Rust: Change canonical paths for trait items
8a9ef4c
Use `crate::Trait::foo` instead of `<_ as crate::Trait>::foo` for trait items.
@hvitved
Rust: Update trait item canonical path references
2a7c932
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@hvitved
Rust: Document trait item canonical path change
f902541
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a15104d-a9a3-4506-8325-203af6db47f8
@github-actionsgithub-actionsBot
added

documentation

Rust
Pull requests that update Rust code
labels
Aug 19, 2026
@hvitved
hvitved
requested a balanced review from CopilotAugust 19, 2026 08:31
CopilotAI
reviewed
Aug 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Changes Rust trait-item canonical paths to the simpler Trait::item format and migrates affected models, documentation, and generated expectations.
Changes:
  • Updates canonical-path generation for trait items.
  • Migrates Rust library and test models to the new format.
  • Updates documentation, change notes, and generated expectations.
Show a summary per file
FileDescription
rust/ql/test/query-tests/security/CWE-918/RequestForgery.expectedRegenerates request-forgery expectations.
rust/ql/test/query-tests/security/CWE-798/HardcodedCryptographicValue.expectedRegenerates cryptographic-value expectations.
rust/ql/test/query-tests/security/CWE-770/UncontrolledAllocationSize.expectedRegenerates allocation-size expectations.
rust/ql/test/query-tests/security/CWE-312/CleartextLogging.expectedRegenerates logging expectations.
rust/ql/test/query-tests/security/CWE-117/LogInjection.expectedRegenerates log-injection expectations.
rust/ql/test/query-tests/security/CWE-079/warp/XSS.expectedRegenerates Warp XSS expectations.
rust/ql/test/query-tests/security/CWE-022/TaintedPath.expectedRegenerates tainted-path expectations.
rust/ql/test/library-tests/dataflow/strings/inline-taint-flow.expectedUpdates string data-flow expectations.
rust/ql/test/library-tests/dataflow/sources/web_frameworks/InlineFlow.expectedUpdates web-framework model expectations.
rust/ql/test/library-tests/dataflow/sources/env/InlineFlow.expectedUpdates environment-source expectations.
rust/ql/test/library-tests/dataflow/sources/database/InlineFlow.expectedUpdates database-source expectations.
rust/ql/test/library-tests/dataflow/models/models.ext.ymlMigrates test extension models.
rust/ql/test/library-tests/dataflow/models/models.expectedRegenerates model expectations.
rust/ql/test/library-tests/dataflow/modeled/inline-flow.expectedUpdates modeled-flow expectations.
rust/ql/test/library-tests/dataflow/local/inline-flow.expectedUpdates local-flow expectations.
rust/ql/test/library-tests/dataflow/global/inline-flow.expectedUpdates global-flow expectations.
rust/ql/test/library-tests/dataflow/collections/inline-flow.expectedUpdates collection-flow expectations.
rust/ql/test/extractor-tests/canonical_path/canonical_paths.expectedVerifies new extracted canonical paths.
rust/ql/lib/codeql/rust/internal/PathResolution.qllImplements the new trait-item path format.
rust/ql/lib/codeql/rust/frameworks/warp.model.ymlMigrates Warp trait models.
rust/ql/lib/codeql/rust/frameworks/tokio/io.model.ymlMigrates Tokio I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/io.model.ymlMigrates standard I/O trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.ymlMigrates core trait models.
rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.ymlMigrates allocation trait models.
rust/ql/lib/codeql/rust/frameworks/sqlx.model.ymlMigrates SQLx trait models.
rust/ql/lib/codeql/rust/frameworks/rustcrypto/rustcrypto.model.ymlMigrates RustCrypto trait models.
rust/ql/lib/codeql/rust/frameworks/mysql.model.ymlMigrates MySQL trait models.
rust/ql/lib/codeql/rust/frameworks/mysql-async.model.ymlMigrates asynchronous MySQL models.
rust/ql/lib/codeql/rust/frameworks/futures.model.ymlMigrates Futures I/O models.
rust/ql/lib/codeql/rust/frameworks/asyncstd/io.model.ymlMigrates async-std I/O models.
rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qllUpdates an internal path reference.
rust/ql/lib/change-notes/2026-08-19-trait-canonical-paths.mdDocuments the model migration.
docs/codeql/codeql-language-guides/customizing-library-models-for-rust.rstDocuments the new canonical-path syntax.
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
  • Files reviewed: 39/39 changed files
  • Comments generated: 1
  • Review effort level: Balanced
Comment threadrust/ql/lib/codeql/rust/frameworks/tokio/io.model.yml
Outdated

@hvitved
Potential fix for pull request finding
4f48b45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hvitved
hvitved
marked this pull request as ready for review
August 19, 2026 12:15
@hvitved
hvitved
requested review from
a team
as code ownersAugust 19, 2026 12:15
@hvitved
hvitved
requested a review
from redsun82August 19, 2026 18:04
@hvitvedhvitved
mentioned this pull request
Aug 20, 2026
 Merged

@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
use crate::Trait::item canonical paths for Rust trait items instead of <_ as crate::Trait>::item
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
@hvitved
hvitved
commented
Aug 20, 2026

Copy link


Copy Markdown

ContributorAuthor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
@redsun82
redsun82
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
This may have already been discussed but ... is there an issue with ambiguity with crate::Trait::item vs simple functions such as core::ptr::read now?
I don't think that is possible, since that would require Trait to exist as both a trait and a module in the same namespace, which is not allowed.
yep, that's my understanding as well.
@hvitved
hvitved
merged commit 79d40e6
into
mainAug 20, 2026

22 checks passed

@hvitved
hvitved
deleted the

hvitved-rust-canonical-paths

branch
August 20, 2026 12:50
@geoffw0
geoffw0
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Thanks. 👍
@hvitvedhvitved
mentioned this pull request
Aug 28, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@redsun82redsun82redsun82 approved these changes

Assignees


No one assigned


Labels

documentationRustPull requests that update Rust code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@hvitved@geoffw0@redsun82