C#: Use ProcessStartInfo built-in for correct escaping/quoting in the Dependency manager.

[michaelnebel]

Instead of escaping/quoting of arguments when we invoke dotnet in the dependency manager, we should rely on the built-in support in ProcessStartInfo. That is, we should supply the arguments to the call via ArgumentList instead of Arguments (documentation can be seen here).

DCA looks good.

Also ran QA (note - this is only internally visible for GitHub), which showed significant extraction regressions for some repos (among others the dotnet/project-system). However, Iattempted to do the extraction locally and didn't observe a similar regression. Will run QA again just to make sure.

• Issue with link to dashboard that shows regressions can be seen here.
• Issue with link to dashboard that doesn't show any regressions can be seen here. It is worth noting that baseline variant failed to execute in several thousand repositories. However, from the "Run list" we can see that vsvim/vsvim, dotnet/project-system, microsoft/nodejstools and microsoft/ptvs succeeded in both variants and the execution times are similar (these were the outliers in the first QA run).

[Copilot]

Pull request overview

Migrates dependency-manager process invocation from manually quoted strings to structured argument lists for reliable escaping.

Changes:

• Refactors .NET and NuGet invocations to use argument lists.
• Updates feed-source and restore APIs accordingly.
• Adapts tests and source-generator execution.

Show a summary per file

File	Description
Runtime.cs	Updates the IDotNet test stub.
DotNet.cs (tests)	Adapts command-construction tests.
DotnetSourceGeneratorWrapper.cs	Passes compiler arguments separately.
PackagesConfigRestorer.cs	Uses structured NuGet arguments.
NugetPackageRestorer.cs	Propagates source argument lists.
IDotNetCliInvoker.cs	Changes invoker methods to list arguments.
IDotNet.cs	Updates public command and restore contracts.
FeedManager.cs	Produces structured source arguments.
DotNetCliInvoker.cs	Starts processes with argument lists.
DotNet.cs (dependency fetching)	Constructs all CLI commands as argument lists.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 10/10 changed files
• Comments generated: 2
• Review effort level: Balanced

[Copilot]

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[hvitved]

LGTM