Uh oh!
There was an error while loading. Please reload this page.
C#: Harden cs/useless-cast-to-self with respect to unknown types. - #22393
Merged
michaelnebel merged 2 commits intoAug 20, 2026
Merged
Conversation
michaelnebelforce-pushed
the
csharp/useless-cast-to-self-unknown-type
branch
from
August 20, 2026 07:31
75481e2 to
97985c8Comparemichaelnebel
marked this pull request as ready for review
August 20, 2026 09:16
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents false positives from unknown C# types, especially in buildless databases.
Changes:
- Excludes
UnknownTypefrom redundant self-cast results. - Documents the behavior change.
Show a summary per file
| File | Description |
|---|---|
csharp/ql/src/Language Abuse/UselessCastToSelf.ql | Filters casts involving unknown types. |
csharp/ql/src/change-notes/2026-08-20-harden-useless-cast-to-self.md | Adds the fix note. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| type = cast.getTargetType() and | ||
| type = e.getType() and | ||
| not type instanceof NullType and | ||
| not type instanceof UnknownType and |
hvitved
approved these changes
Aug 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially for
build-mode: noneexpressions can more easily be of unknown type (and the same goes for types used in casts). Such cases should not be reported by the querycs/useless-cast-to-self.This change removes around 7k results across the repos in the DCA suite.