Skip to content

Rust: Exclude 'unused variable' results for functions containing todo!() or unimplemented!()#22398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 2 commits into from
Aug 21, 2026
Merged

Rust: Exclude 'unused variable' results for functions containing todo!() or unimplemented!()#22398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42c07b3
Rust: Exclude 'unused variable' results for functions containing `tod…
hvitved Aug 20, 2026
bbff992
Add change note
hvitved Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rust/ql/src/change-notes/2026-08-20-unused-variables-in-incomplete-functions.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The `rust/unused-variable` query no longer reports variables in functions containing the standard `todo!()` or `unimplemented!()` macros.
9 changes: 7 additions & 2 deletions rust/ql/src/queries/unusedentities/UnusedVariable.qll
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import rust
private import codeql.rust.internal.PathResolution

/**
* A deliberately unused variable, for example `_` or `_x`.
Expand All@@ -23,9 +24,13 @@ predicate isUnused(Variable v) {
*/
class IncompleteCallable extends Callable {
IncompleteCallable() {
exists(MacroExpr me |
me.getEnclosingCallable() = this and
exists(MacroExpr me | me.getEnclosingCallable() = this |
not me.getMacroCall().hasMacroCallExpansion()
or
exists(ItemNode i |
i.getCanonicalPath(_) = ["core::macros::unimplemented", "core::macros::todo"] and
me.getMacroCall().resolveMacro() = i
)
)
}
}
Expand Down
8 changes: 8 additions & 0 deletions rust/ql/test/query-tests/unusedentities/main.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -558,6 +558,14 @@ trait MyTrait {
fn my_func2(&self, x: i32) -> i32;
}

fn unimplemented(x : i32) {
unimplemented!()
}

fn todo(x : i32) {
todo!()
}

// --- main ---

fn main() {
Expand Down
Loading