Uh oh!
There was an error while loading. Please reload this page.
Unified: Make Linux build hermetic - #22413
Merged
Merged
Conversation
jketemaforce-pushed
the
jketema/swift-static
branch
from
August 24, 2026 12:40
b82815a to
0f1fd7fComparejketema
marked this pull request as ready for review
August 24, 2026 13:06
Contributor
There was a problem hiding this comment.
Pull request overview
Makes Linux Swift builds hermetic by supporting an externally supplied static Swift runtime.
Changes:
- Adds static-runtime constraints and rules_swift integration.
- Selects static or dynamic runtime linkage by platform.
- Removes legacy runtime helpers and adjusts packaging.
Show a summary per file
| File | Description |
|---|---|
BUILD.bazel | Defines the static Swift runtime constraint. |
MODULE.bazel | Marks Swift toolchain setup as development-only. |
unified/BUILD.bazel | Removes runtime libraries from extractor packaging. |
unified/extractor/BUILD.bazel | Uses the unified runtime target as data. |
unified/swift-syntax-rs/BUILD.bazel | Adds static/dynamic runtime selection and linker grouping. |
unified/swift-syntax-rs/swift_runtime.bzl | Removes the legacy runtime-file filter. |
unified/swift-syntax-rs/swift_runtime_linking.bzl | Removes the legacy runtime-linking rule. |
misc/bazel/registry/modules/rules_swift/4.0.0-rc5-codeql.1/source.json | Registers the new rules_swift patch. |
misc/bazel/registry/modules/rules_swift/4.0.0-rc5-codeql.1/patches/external_static_runtime.patch | Adds external static-runtime support to rules_swift. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Balanced
| "//unified/extractor", | ||
| "//unified/swift-syntax-rs:swift_runtime_libs", | ||
| ], | ||
| linux64 = ["//unified/extractor"], |
ContributorAuthor
There was a problem hiding this comment.
That's correct and needed when building from this repo (no access to the static libraries).
redsun82
approved these changes
Aug 24, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are expected to fail here, as they depend on internal changes.