Uh oh!
There was an error while loading. Please reload this page.
Unified: Enable on Arm64 - #22478
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documented packaging script still mislabels Arm64 builds as linux64.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 | unified/BUILD.bazel — This enables the Bazel package path, but the documented unified/scripts/create-extractor-pack.sh… |
What changed in this PR
Enables building and packaging the Unified extractor on Linux Arm64.
Changes:
- Packages the real Unified extractor for Linux Arm64.
- Registers the Arm64 Swift toolchain.
| File | Description |
|---|---|
unified/BUILD.bazel | Enables the Arm64 extractor binary. |
MODULE.bazel | Exposes and registers the Arm64 Swift toolchain. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| exes = codeql_platform_select( | ||
| linux64 = ["//unified/extractor"], | ||
| linux_arm64 = ["//unified/extractor-unsupported-os:extractor"], | ||
| linux_arm64 = ["//unified/extractor"], |
There was a problem hiding this comment.
Fair, but these are broken all over the place. We should probably find a way to get rid of most or all of them.
| exes = codeql_platform_select( | ||
| linux64 = ["//unified/extractor"], | ||
| linux_arm64 = ["//unified/extractor-unsupported-os:extractor"], | ||
| linux_arm64 = ["//unified/extractor"], | ||
| osx64 = ["//unified/extractor"], | ||
| win64 = ["//unified/extractor-unsupported-os:extractor"], |
There was a problem hiding this comment.
at this point we can simplify to
exes=codeql_platform_select(
win64= ["//unified/extractor-unsupported-os:extractor"],
otherwise= ["//unified/extractor"],
),There was a problem hiding this comment.
Let me get this merged and do a small follow-up.
Uh oh!
There was an error while loading. Please reload this page.
No description provided.