Uh oh!
There was an error while loading. Please reload this page.
C++: Fix test I broke by accident - #22512
Merged
Merged
Conversation
tausbn
approved these changes
Sep 4, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The test expectation update is focused, and no unresolved issues were found.
Review tier: Balanced
Findings: None
What changed in this PR
Updates C++ MaD signature test expectations for existing BlobUtil::copy models.
Changes:
- Adds expected parameter names and types for three
BlobUtil::copysignatures.
| File | Description |
|---|---|
cpp/ql/test/library-tests/dataflow/taint-tests/test_mad-signatures.expected | Updates expected signature parameter output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jketema
commented
Sep 4, 2026
ContributorAuthor
Language test pass, merging. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.