'cleanup caches' example workflow is wrong and harmful!

[andreasabel]

Code of Conduct

• I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries

Lifted from:

• 'cleanup caches' example workflow is wrong and harmful! #23530

The workflow that is supposed to delete PR-caches deletes caches from master/base branch:

docs/content/actions/using-workflows/caching-dependencies-to-speed-up-workflows.md

Lines 330 to 347 in 4f05492

	pull_request:
	types:
	- closed
	workflow_dispatch:
	jobs:
	cleanup:
	runs-on: ubuntu-latest
	steps:
	- name: Check out code
	uses: {% data reusables.actions.action-checkout %}
	- name: Cleanup
	run: |
	gh extension install actions/gh-actions-cache
	REPO={% raw %}${{ github.repository }}{% endraw %}
	BRANCH={% raw %}${{ github.ref }}{% endraw %}

This looks logical, but seems to be wrong. If invoked by a closing PR, BRANCH ends up to be the base branch, e.g. master. This job will then remove exactly the wrong caches.

Should be fixed immediately by some knowledgeable person. Or at least add the disclaimer I suggested in the PR.

Evidence here: https://github.com/agda/agda/actions/runs/4025940394/jobs/6919801891#step:3:5
(Note: these logs will be removed by github after some time.)

What part(s) of the article would you like to see updated?

See above.

Additional information

No response

[welcome]

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

[cmwilson21]

@andreasabel Thanks for opening an issue! I've edited your post slightly to include the article in question. 👍

I'll get this triaged for review! ⚡

[JacobKlipper]

Labels yesterday seems like the best of choices after reading this article highly agree

[lucascosti]

Looks like this was fixed in another PR recently: #23612

Thanks for the issue!