Uh oh!
There was an error while loading. Please reload this page.
chore: Remove locales from docs.microsoft.com urls - #1011
Merged
Conversation
SMAKSS
approved these changes
Nov 3, 2020
SMAKSS
left a comment
Contributor
There was a problem hiding this comment.
Well, I tried this with some different languages by changing the browser language and it is working as expected.
janiceilene
commented
Nov 4, 2020
Contributor
Thanks @nschonni! I'll triage this for a content review, as well. |
nschonniforce-pushed
the
remove-microsoft-locales
branch
2 times, most recently
from
November 4, 2020 21:22
5377aeb to
758429aComparenschonniforce-pushed
the
remove-microsoft-locales
branch
from
November 4, 2020 21:23
758429a to
4bc4851CompareContributor
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
jnidzwetzki pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* Update Prometheus config * Update promscale/send-data/prometheus.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update promscale/send-data/prometheus.md Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Lana Brindley <github@lanabrindley.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Microsoft links automatically direct to the users locale when it is removed from the URLs. This is also done for the docs.microsoft.com content in order to improve localization of content. There were changes to the translated content in the cleanup, but it wasn't committed here, so it would flow through the regular translation flow.
What's being changed:
Ran the cleanup from https://github.com/microsoft/vscode-docs-authoring/ to strip locales from MS urls
Check off the following: