Skip to content

Document reusable workflow limitation - #11831

Merged
skedwards88 merged 3 commits into
github:mainfrom
cmitz:patch-2
Dec 1, 2021
Merged

Document reusable workflow limitation#11831
skedwards88 merged 3 commits into
github:mainfrom
cmitz:patch-2

Conversation

@cmitz

@cmitzcmitz commented Nov 10, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Why:

Closes#11830

I discovered that reusable workflows do not support the strategy property and that was not documented anywhere. So, I added that to the list of limitations.

That issue, however, still needs to be confirmed.

What's being changed:

Very little is being changed. Just one line with a limitation was added to an existing list.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@cmitz
Document reusable workflow limitation
450e596
I discovered that reusable workflows do not support the `strategy` property and that was not documented anywhere.
@welcome

welcomeBot commented Nov 10, 2021

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actionsgithub-actionsBot added the triage Do not begin working on this issue until triaged by the team label Nov 10, 2021
@github-actions

github-actionsBot commented Nov 10, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

SourceStagingProductionWhat Changed
content/actions/learn-github-actions/reusing-workflows.mdModifiedOriginal

@ramyaparimiramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 11, 2021
@ramyaparimi

ramyaparimi commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

@cmitz
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@skedwards88

skedwards88 commented Nov 30, 2021

Copy link
Copy Markdown
Contributor

Closing via #11830 (comment)

@skedwards88skedwards88 reopened this Dec 1, 2021
@github-actionsgithub-actionsBot added the triage Do not begin working on this issue until triaged by the team label Dec 1, 2021
skedwards88
skedwards88 reviewed Dec 1, 2021
View reviewed changes

@skedwards88skedwards88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR (and for the clarifying issue)! I added a suggestion to clarify that this just applies to jobs that call another workflow. I'll go ahead an incorporate the suggestion then get this merged down for you.

Comment threadcontent/actions/learn-github-actions/reusing-workflows.md Outdated
@skedwards88
skedwards88 enabled auto-merge (squash) December 1, 2021 00:23
@skedwards88skedwards88 added the ready to merge This pull request is ready to merge label Dec 1, 2021
@github-actionsgithub-actionsBot removed the waiting for review Issue/PR is waiting for a writer's review label Dec 1, 2021
@skedwards88
skedwards88 merged commit 066d373 into github:mainDec 1, 2021
@github-actions

github-actionsBot commented Dec 1, 2021

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@cmitz
cmitz deleted the patch-2 branch December 1, 2021 09:39
@snyk-botsnyk-bot mentioned this pull request Jul 15, 2022
Open
@YoYBaByYoYBaBy mentioned this pull request Jul 15, 2022
Open
@YoYBaByYoYBaBy mentioned this pull request Oct 27, 2023
Open
@ashly1111111ashly1111111 mentioned this pull request Oct 27, 2023
Open
@YoYBaByYoYBaBy mentioned this pull request Dec 18, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@skedwards88skedwards88skedwards88 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contentThis issue or pull request belongs to the Docs Content teamready to mergeThis pull request is ready to mergetriageDo not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Listed limitations of reusable workflows incomplete

4 participants

@cmitz@ramyaparimi@skedwards88@docubot