Uh oh!
There was an error while loading. Please reload this page.
Remove note about package immutability - #1193
Conversation
janiceilene
commented
Nov 9, 2020
Thanks for opening a PR @jcansdale! I'll get this triaged for writer review. |
lucascosti
left a comment
There was a problem hiding this comment.
Thanks for this change, @jcansdale!
That reusable is used in a few other articles too:
- https://docs.github.com/en/free-pro-team@latest/packages/managing-container-images-with-github-container-registry/deleting-a-container-image#reserved-package-versions-and-names [source]
- https://docs.github.com/en/free-pro-team@latest/packages/publishing-and-managing-packages/deleting-a-package#reserved-package-versions-and-names [source]
I assume it's incorrect for those too? If so we should remove ☝️ references, and also delete the reusable file.
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
jcansdale
commented
Nov 23, 2020
Sorry I missed your reply. 😊
Yes, there are incorrect as well. |
lucascosti
commented
Nov 24, 2020
Cool, I'll make the changes and get it merged 🚀 |
lucascosti
left a comment
There was a problem hiding this comment.
Looks good to merge when the tests pass ✅
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
The following section isn't true.
We don't reserve the namespace for public packages. Users can delete/move the associated repository or make the repository private and delete individual package versions. The namespace isn't reserved and would cause problems if it was.
I've removed this section to reflect the current behaviour.
What's being changed:
Removed
package-immutabilitysection quoted above.Check off the following: