Skip to content

Fix: Fixed small typo in script/README file - #13138

Closed
bobychaudhary wants to merge 3 commits into
github:mainfrom
bobychaudhary:patch-2
Closed

Fix: Fixed small typo in script/README file#13138
bobychaudhary wants to merge 3 commits into
github:mainfrom
bobychaudhary:patch-2

Conversation

@bobychaudhary

@bobychaudharybobychaudhary commented Dec 18, 2021

Copy link
Copy Markdown

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@bobychaudhary
bobychaudhary requested a review from a team as a code ownerDecember 18, 2021 09:32
@welcome

welcomeBot commented Dec 18, 2021

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@arzpgh60arzpgh60 mentioned this pull request Dec 18, 2021
Closed
1 task
ramyaparimi
ramyaparimi approved these changes Dec 20, 2021
View reviewed changes

@ramyaparimiramyaparimi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobychaudhary
Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@ramyaparimiramyaparimi added content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge labels Dec 20, 2021
@bobychaudharybobychaudhary changed the title Fix: Fixed small type in script/README fileFix: Fixed small typo in script/README fileDec 20, 2021
@bobychaudhary

bobychaudhary commented Dec 27, 2021

Copy link
Copy Markdown
Author

What "Lost" ?

@bobychaudhary
bobychaudhary requested review from ramyaparimi and removed request for a teamJanuary 1, 2022 17:30
@ramyaparimi

ramyaparimi commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

@bobychaudhary I spoke with the team and want to let you know that changes to script/ directory are not accepted. I am going to close this PR now and apologize for the confusion 💛

Thanks so much for contributing to our docs 💖

auto-merge was automatically disabled January 4, 2022 20:14

Pull request was closed

@RanaAhmed2020RanaAhmed2020 mentioned this pull request Nov 30, 2023
Open
@ryan-allyryan-ally mentioned this pull request Nov 30, 2023
Open
@alisccoaliscco mentioned this pull request Dec 1, 2023
Open
@mongoloidkhulmikuki366385mongoloidkhulmikuki366385 mentioned this pull request Dec 1, 2023
Open
@Sarrac3873Sarrac3873 mentioned this pull request May 13, 2024
Open
@ryan-allyryan-ally mentioned this pull request May 14, 2024
Open
@alisccoaliscco mentioned this pull request May 17, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramyaparimiramyaparimiAwaiting requested review from ramyaparimi

Assignees

No one assigned

Labels

contentThis issue or pull request belongs to the Docs Content teamready to mergeThis pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobychaudhary@ramyaparimi