Uh oh!
There was an error while loading. Please reload this page.
Typo in the example code - #1316
Merged
Merged
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
janiceilene
commented
Nov 16, 2020
Contributor
@ariG23498 Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Contributor
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
janiceilene
commented
Nov 24, 2020
Contributor
Thanks for your patience @ariG23498! Our small team is working our way through all the amazing contributions ✨ |
ariG23498
commented
Nov 25, 2020
ContributorAuthor
Thank you for the reply. I am eager to getting this PR merged 😄 |
shati-patel
approved these changes
Dec 2, 2020
shati-patel
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing the typo, @ariG23498! We really appreciate all these contributions to help improve our docs 😊
I'll get this merged shortly!
Contributor
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Octomerger pushed a commit
that referenced
this pull request
Dec 6, 2021
* static assets should not use csrf (Set-Cookie) Part of #1316 * move setFastlySurrogateKey up too
Octomerger added a commit
that referenced
this pull request
Dec 9, 2021
* 301 redirects should not set-cookie Part of #1316 * Update release-notes.js * No public facing doc changes (#23355) Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com> * New translation batch for pt (#23362) * Add crowdin translations * Run script/i18n/homogenize-frontmatter.js * Run script/i18n/fix-translation-errors.js * Run script/i18n/lint-translation-files.js --check parsing * Run script/i18n/lint-translation-files.js --check rendering * run script/i18n/reset-known-broken-translation-files.js * Check in pt CSV report * 24h cache all internal redirects without language prefix (#23354) Part of #1271 * Redirects for root path should not set-cookie in all supported languages (#23377) * test: add case when unsupported language is specified in redirect * test: assert root redirects to appropriate language preference if specified * refactor: remove redundant unit test * refactor: re-order units starting with affirmative case * refactor: remove single-use variable from unit * fix: re-include previous unit with udpated description Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com> Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com> Co-authored-by: Rogan Ferguson <40493721+roferg@users.noreply.github.com> Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com> Co-authored-by: docubot <67483024+docubot@users.noreply.github.com> Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com> Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
jnidzwetzki pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* Add video to documentation * Clean up queries Co-authored-by: Lana Brindley <github@lanabrindley.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small typo in the comments.
Why:
I am suggesting this change becuase I have found a small
typoin the code. Thelatest ubuntudid not have thetin place.What's being changed:
A spelling mistake is being taken care of. In the github actions quickstart guide, the spelling of
latesthas a missingt.Check off the following: