Uh oh!
There was an error while loading. Please reload this page.
chore: Convert Standard to eslint-config-standard - #1328
Conversation
There was a problem hiding this comment.
I'm curious about thoughts on including the eslint config and ignore in package.json instead of as separate files.
There was a problem hiding this comment.
I believe the separate ignore file usually has better performance, but I've not looked at using the inline config in package.json before
heiskr
left a comment
There was a problem hiding this comment.
This looks like a good change to me and one that I've run into personally.
chiedo
commented
Nov 17, 2020
@nschonni thanks for creating this! Can you resolve the conflicts 🙏🏿 |
7334057 to
591bff9Compare- .filter must return a boolean value - .map replaced with forEach when the value isn't used
591bff9 to
795a74cComparenschonni
commented
Nov 17, 2020
@chiedo done! |
chiedo
commented
Nov 17, 2020
Just want one more review on this one! @JasonEtco can you please review! |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
Standard is a wrapper of opionated ESLint rules. By using the direct ESLint config, there is better integration with IDEs for showing ESLint errors while maintaining the existing style preference. Also can drop some of the JSX related dependencies that are bundled as part of the larger
standardpackage.What's being changed:
standardpackage and replace with the ESLint packages forstandardCheck off the following: