Skip to content

Add warning regarding pull_request_target event - #1354

Merged
martin389 merged 8 commits into
github:mainfrom
ylemkimon:patch-1
Dec 15, 2020
Merged

Add warning regarding pull_request_target event#1354
martin389 merged 8 commits into
github:mainfrom
ylemkimon:patch-1

Conversation

@ylemkimon

@ylemkimonylemkimon commented Nov 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Why:

pull_request_target event runs in the context of the base repository, which could be potentially dangerous if it is used to test untrusted code from public forks. It also shares the same scope of cache with the base branch. Closes#1353.

What's being changed:

The red warning box is shown below the description of pull_request_target

Check off the following:

@welcome

welcomeBot commented Nov 15, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Mambai91
Mambai91 approved these changes Nov 15, 2020
View reviewed changes
Comment threadcontent/actions/reference/events-that-trigger-workflows.md Outdated
@janiceilene

janiceilene commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

@ylemkimon Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilenejaniceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 16, 2020
@github-actions

github-actionsBot commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added the stale There is no recent activity on this issue or pull request label Nov 24, 2020
@ylemkimon

This comment has been minimized.

Sign in to view
@janiceilenejaniceilene removed the stale There is no recent activity on this issue or pull request label Nov 24, 2020
@janiceilene

janiceilene commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

Thanks for your patience @ylemkimon! Our small team is working our way through all the amazing contributions ✨

@github-actions

github-actionsBot commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added the stale There is no recent activity on this issue or pull request label Dec 1, 2020
@janiceilenejaniceilene removed the stale There is no recent activity on this issue or pull request label Dec 3, 2020
martin389
martin389 reviewed Dec 4, 2020
View reviewed changes
Comment threadcontent/actions/reference/events-that-trigger-workflows.md Outdated
@ylemkimon@martin389
Update content/actions/reference/events-that-trigger-workflows.md
a8cab92
Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>
@janiceilene

janiceilene commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

@martin389 It looks like @ylemkimon incorporated your suggestions 🎉 Can you add a ready to merge label if this PR is all set?

@martin389

martin389 commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

Thanks @janiceilene! For the next step, I'm checking that support approves this guidance 👍

@martin389martin389 self-assigned this Dec 14, 2020
elstudio
elstudio approved these changes Dec 14, 2020
View reviewed changes

@elstudioelstudio left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- and a very very good thing to warn folks about!

@martin389
martin389 merged commit 7ee0f93 into github:mainDec 15, 2020
@github-actions

github-actionsBot commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@martin389

martin389 commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

Thank you @ylemkimon! 👍

@ylemkimon

ylemkimon commented Dec 18, 2020

Copy link
Copy Markdown
ContributorAuthor

Thank you everyone for your reviews and the great work at GitHub!

@snyk-botsnyk-bot mentioned this pull request Sep 26, 2021
Open
This was referenced Nov 14, 2021
Open
Open
@snyk-botsnyk-bot mentioned this pull request Feb 20, 2022
Open
@JennyLin0625JennyLin0625 mentioned this pull request May 21, 2022
Open
@thangnguyen2001thangnguyen2001 mentioned this pull request Oct 20, 2023
Open
@jacksonbinh4jacksonbinh4 mentioned this pull request Jan 22, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@martin389martin389martin389 left review comments
@elstudioelstudioelstudio approved these changes
@Mambai91Mambai91Mambai91 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@martin389martin389

Labels

actionsThis issue or pull request should be reviewed by the docs actions teamcontentThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add warning regarding pull_request_target event

5 participants

@ylemkimon@janiceilene@martin389@elstudio@Mambai91