Skip to content

Clarify GH password requirements - #1395

Merged
shati-patel merged 2 commits into
github:mainfrom
hongshaoyang:patch-1
Dec 2, 2020
Merged

Clarify GH password requirements#1395
shati-patel merged 2 commits into
github:mainfrom
hongshaoyang:patch-1

Conversation

@hongshaoyang

@hongshaoyanghongshaoyang commented Nov 17, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Why:

Closes#1396 .

What's being changed:

The password requirements are missing the phrase "at least". Without this phrase, it seems like the password requirements must be exactly eight or 16 characters long.

Check off the following:

@welcome

welcomeBot commented Nov 17, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

janiceilene commented Nov 17, 2020

Copy link
Copy Markdown
Contributor

@hongshaoyang Thanks so much for opening a PR! I'll get this triaged for review 🌟

@janiceilenejaniceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 17, 2020
@github-actions

github-actionsBot commented Nov 28, 2020

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@hongshaoyang

hongshaoyang commented Nov 29, 2020

Copy link
Copy Markdown
ContributorAuthor

@janiceilene any updates on this PR?

@github-actionsgithub-actionsBot removed the stale There is no recent activity on this issue or pull request label Nov 29, 2020
@janiceilene

janiceilene commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

@hongshaoyang Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@shati-patelshati-patel self-assigned this Dec 2, 2020
shati-patel
shati-patel approved these changes Dec 2, 2020
View reviewed changes

@shati-patelshati-patel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your change, @hongshaoyang! We really appreciate all the community contributions to help improve our docs 😊

I'll get this merged shortly!

@shati-patel
shati-patel merged commit 1d7acfa into github:mainDec 2, 2020
@github-actions

github-actionsBot commented Dec 2, 2020

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@hongshaoyang
hongshaoyang deleted the patch-1 branch December 2, 2020 15:27
@hongshaoyang

hongshaoyang commented Dec 2, 2020

Copy link
Copy Markdown
ContributorAuthor

thanks @shati-patel

This was referenced Jun 17, 2021
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@shati-patelshati-patelshati-patel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@shati-patelshati-patel

Labels

contentThis issue or pull request belongs to the Docs Content team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Password requirements are misleading

3 participants

@hongshaoyang@janiceilene@shati-patel