Skip to content

Include work around for wildcards in HTTP Proxy Exclusion list - #1501

Merged
martin389 merged 8 commits into
github:mainfrom
mzzmjd:patch-1
Jan 8, 2021
Merged

Include work around for wildcards in HTTP Proxy Exclusion list#1501
martin389 merged 8 commits into
github:mainfrom
mzzmjd:patch-1

Conversation

@mzzmjd

@mzzmjdmzzmjd commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

Why:

What's being changed:

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome

welcomeBot commented Nov 20, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@mzzmjd

mzzmjd commented Nov 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Link to #1501 1502

@mzzmjd
mzzmjd marked this pull request as ready for review November 20, 2020 15:40
@janiceilenejaniceilene linked an issue Nov 20, 2020 that may be closed by this pull request
Include work around for wildcards in HTTP Proxy Exclusion list on GHES #1502
Closed
@janiceilene

janiceilene commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

@mzzmjd Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@github-actions

github-actionsBot commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added the stale There is no recent activity on this issue or pull request label Dec 3, 2020
@brntbeer

brntbeer commented Dec 22, 2020

Copy link
Copy Markdown
Member

@mzzmjd Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@mzzmjd Would you mind taking a look at the pull request template (here: https://raw.githubusercontent.com/github/docs/main/.github/PULL_REQUEST_TEMPLATE.md) and add it to your opening post so we can go about reviewing and merging this?

@brntbeerbrntbeer reopened this Dec 22, 2020
@github-actionsgithub-actionsBot removed the stale There is no recent activity on this issue or pull request label Dec 23, 2020
@github-actions

github-actionsBot commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added stale There is no recent activity on this issue or pull request and removed stale There is no recent activity on this issue or pull request labels Dec 30, 2020
martin389
martin389 reviewed Dec 31, 2020
View reviewed changes
Comment threadcontent/admin/configuration/configuring-an-outbound-web-proxy-server.md Outdated
@martin389martin389 self-assigned this Dec 31, 2020
@martin389

martin389 commented Dec 31, 2020

Copy link
Copy Markdown
Contributor

Summary

This PR addresses #1502

Changes in this PR

Article in stagingChanges
“Configuring an outbound web proxy server”Adds a line to step 5, explaining how to use a wildcard for outbound proxy configuration.

Tests

All tests are passing! 🍏

@martin389martin389 added content This issue or pull request belongs to the Docs Content team core labels Dec 31, 2020
@martin389

martin389 commented Dec 31, 2020

Copy link
Copy Markdown
Contributor

Checking this approach with the support team.

@martin389

martin389 commented Jan 7, 2021

Copy link
Copy Markdown
Contributor

Support have confirmed they're happy with this approach 👍 Now working on merging this PR.

This was referenced Sep 30, 2022
Open
Open
@ramsemuneramsemune mentioned this pull request Oct 5, 2022
Open
@shga1993shga1993 mentioned this pull request Oct 5, 2022
Open
@dev2darkdev2dark mentioned this pull request Oct 5, 2022
Open
@zipzip225zipzip225 mentioned this pull request Oct 5, 2022
Open
@Jsn2winJsn2win mentioned this pull request Oct 5, 2022
Open
@onuronur76onuronur76 mentioned this pull request Oct 5, 2022
Open
@machatmanmachatman mentioned this pull request Oct 5, 2022
Open
@onuronur76onuronur76 mentioned this pull request Oct 6, 2022
Open
@treeationstreeations mentioned this pull request Oct 6, 2022
Open
@machatmanmachatman mentioned this pull request Oct 6, 2022
Open
@tronghamtrongham mentioned this pull request Oct 6, 2022
Open
@ramsemuneramsemune mentioned this pull request Oct 6, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 6, 2022
Open
@shga1993shga1993 mentioned this pull request Oct 6, 2022
Open
@ayvazjetayvazjet mentioned this pull request Oct 7, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 7, 2022
Open
@treeationstreeations mentioned this pull request Oct 7, 2022
Open
@bonachylaurielbonachylauriel mentioned this pull request Oct 7, 2022
Open
@tronghamtrongham mentioned this pull request Oct 7, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 7, 2022
Open
@Verdinjoshua26Verdinjoshua26 mentioned this pull request Oct 9, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 9, 2022
Open
@bonachylaurielbonachylauriel mentioned this pull request Oct 9, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 9, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Jan 12, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Feb 14, 2023
Open
@B020239B020239 mentioned this pull request Jun 30, 2023
Open
@githubgithub locked as spam and limited conversation to collaborators May 12, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@martin389martin389martin389 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@martin389martin389

Labels

contentThis issue or pull request belongs to the Docs Content team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include work around for wildcards in HTTP Proxy Exclusion list on GHES

4 participants

@mzzmjd@janiceilene@brntbeer@martin389