Skip to content

fix: Links to localhost addresses - #1505

Merged
lucascosti merged 3 commits into
github:mainfrom
nschonni:localhost-links
Dec 15, 2020
Merged

fix: Links to localhost addresses#1505
lucascosti merged 3 commits into
github:mainfrom
nschonni:localhost-links

Conversation

@nschonni

@nschonninschonni commented Nov 20, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Why:

Rather than ignoring localhost links in the linter, it's better to just not directly link to them

What's being changed:

Change localhost links to code blocks

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@nschonni
nschonni requested a review from a team as a code ownerNovember 20, 2020 16:43
nschonni
nschonni commented Nov 20, 2020
View reviewed changes
Comment threadcontent/developers/apps/authorizing-oauth-apps.md Outdated
@janiceilene

janiceilene commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

@nschonni Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilenejaniceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 20, 2020
@github-actions

github-actionsBot commented Nov 28, 2020

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@nschonni
fix: Links to localhost addresses
6d721e1
Put them in code blocks and stop ignoring them from link checking
heiskr
heiskr approved these changes Nov 30, 2020
View reviewed changes

@heiskrheiskr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@janiceilenejaniceilene removed the stale There is no recent activity on this issue or pull request label Dec 1, 2020
@github-actions

github-actionsBot commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added the stale There is no recent activity on this issue or pull request label Dec 9, 2020
@janiceilenejaniceilene removed the stale There is no recent activity on this issue or pull request label Dec 9, 2020
@lucascostilucascosti self-assigned this Dec 15, 2020
lucascosti
lucascosti approved these changes Dec 15, 2020
View reviewed changes

@lucascostilucascosti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @nschonni, thanks for this change! I'll just commit the one suggestion and then merge this in 🚀

Comment threadcontent/developers/apps/authorizing-oauth-apps.md Outdated
@lucascosti
lucascosti merged commit f1f7c95 into github:mainDec 15, 2020
@github-actions

github-actionsBot commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@nschonni
nschonni deleted the localhost-links branch December 15, 2020 06:59
This was referenced Jun 19, 2022
Open
Open
@BESTczmBESTczm mentioned this pull request Jun 19, 2022
Open
@RanaAhmed2020RanaAhmed2020 mentioned this pull request Jun 19, 2022
Open
@Jsn2winJsn2win mentioned this pull request Jun 19, 2022
Open
@ZRDKZRDK mentioned this pull request Jun 19, 2022
Open
This was referenced Jun 19, 2022
Open
Open
Open
This was referenced Sep 30, 2022
Open
Open
@ramsemuneramsemune mentioned this pull request Oct 5, 2022
Open
@shga1993shga1993 mentioned this pull request Oct 5, 2022
Open
@dev2darkdev2dark mentioned this pull request Oct 5, 2022
Open
@zipzip225zipzip225 mentioned this pull request Oct 5, 2022
Open
@Jsn2winJsn2win mentioned this pull request Oct 5, 2022
Open
@onuronur76onuronur76 mentioned this pull request Oct 5, 2022
Open
@machatmanmachatman mentioned this pull request Oct 5, 2022
Open
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@charislam@Loquacity
Add link to chunk time blog (github#1505)
45dd85c
Add link to the chunk time blog post, which is a good extended
discussion of how to optimize time partitions.
Co-authored-by: Lana Brindley <github@lanabrindley.com>
@onuronur76onuronur76 mentioned this pull request Oct 6, 2022
Open
@treeationstreeations mentioned this pull request Oct 6, 2022
Open
@machatmanmachatman mentioned this pull request Oct 6, 2022
Open
@tronghamtrongham mentioned this pull request Oct 6, 2022
Open
@ramsemuneramsemune mentioned this pull request Oct 6, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 6, 2022
Open
@shga1993shga1993 mentioned this pull request Oct 6, 2022
Open
@ayvazjetayvazjet mentioned this pull request Oct 7, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 7, 2022
Open
@treeationstreeations mentioned this pull request Oct 7, 2022
Open
@bonachylaurielbonachylauriel mentioned this pull request Oct 7, 2022
Open
@tronghamtrongham mentioned this pull request Oct 7, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 7, 2022
Open
@Verdinjoshua26Verdinjoshua26 mentioned this pull request Oct 9, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 9, 2022
Open
@bonachylaurielbonachylauriel mentioned this pull request Oct 9, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 9, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Jan 12, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Feb 14, 2023
Open
@B020239B020239 mentioned this pull request Jun 30, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heiskrheiskrheiskr approved these changes
+1 more reviewer
@lucascostilucascostilucascosti approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lucascostilucascosti

Labels

contentThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nschonni@janiceilene@heiskr@lucascosti