Skip to content

Update libraries.md to include python client for GitHub's REST API that uses the OpenAPI Spec - #1607

Merged
skedwards88 merged 2 commits into
mainfrom
hamelsmu-add-ghapi
Dec 3, 2020
Merged

Update libraries.md to include python client for GitHub's REST API that uses the OpenAPI Spec#1607
skedwards88 merged 2 commits into
mainfrom
hamelsmu-add-ghapi

Conversation

@hamelsmu

@hamelsmuhamelsmu commented Nov 25, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Why:

Including a new python client that is using GitHub's newly published open api spec!

What's being changed:

Adding a new python client to the docs

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

cc: @jph00

@welcome

welcomeBot commented Nov 25, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@hamelsmuhamelsmu changed the title [WIP] Update libraries.mdUpdate libraries.md to include python client for GitHub's REST APINov 25, 2020
@hamelsmu
hamelsmu marked this pull request as ready for review November 25, 2020 22:18
@hamelsmuhamelsmu changed the title Update libraries.md to include python client for GitHub's REST APIUpdate libraries.md to include python client for GitHub's REST API that uses the OpenAPI SpecNov 26, 2020
@dartie1987dartie1987 mentioned this pull request Nov 27, 2020
Closed
@janiceilene

janiceilene commented Nov 30, 2020

Copy link
Copy Markdown
Contributor

Thanks @hamelsmu! I'll get this triaged for review ⚡

@janiceilenejaniceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 30, 2020
Pakphum100
Pakphum100 reviewed Dec 1, 2020
View reviewed changes

@Pakphum100Pakphum100 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[https://globalpts.playtimes.com/windows/index.php?exchangeRate=&dateTimeZone=&token=2a1cbf4919eafd2b187ddef594218a3be990ef83&bankId=itp&playerId=UFAKKAH5008&gameId=00601001005](https://globalpts.playtimes.com/windows/index.php?exchangeRate=&dateTimeZone=&token=2a1cbf4919eafd2b187ddef594218a3be990ef83&bankId=itp&playerId=UFAKKAH5008&gameId=00601001005)

skedwards88
skedwards88 approved these changes Dec 3, 2020
View reviewed changes

@skedwards88skedwards88 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @hamelsmu ! I'll get it merged.

@skedwards88
skedwards88 merged commit 7672308 into mainDec 3, 2020
@skedwards88
skedwards88 deleted the hamelsmu-add-ghapi branch December 3, 2020 02:03
@github-actions

github-actionsBot commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@Pakphum100Pakphum100Pakphum100 left review comments
@skedwards88skedwards88skedwards88 approved these changes
@dartie1987dartie1987dartie1987 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contentThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hamelsmu@janiceilene@skedwards88@Pakphum100@dartie1987