Skip to content

fixes wrong ::set-output name - #17059

Merged
ramyaparimi merged 2 commits into
github:mainfrom
Chrico:patch-2
Apr 22, 2022
Merged

fixes wrong ::set-output name#17059
ramyaparimi merged 2 commits into
github:mainfrom
Chrico:patch-2

Conversation

@Chrico

@ChricoChrico commented Apr 13, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Why:

The documentation uses run: echo "::set-output name=random-id::$(echo $RANDOM)" but the outputs says random-number and the text below as well.

What's being changed:

changes run: echo "::set-output name=random-id::$(echo $RANDOM)" to use random-number

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome

welcomeBot commented Apr 13, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actionsgithub-actionsBot added the triage Do not begin working on this issue until triaged by the team label Apr 13, 2022
@github-actions

github-actionsBot commented Apr 13, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

SourcePreviewProductionWhat Changed
content/actions/creating-actions/creating-a-composite-action.mdModifiedOriginal

@ramyaparimiramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Apr 14, 2022
@github-actions

github-actionsBot commented Apr 14, 2022

Copy link
Copy Markdown
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@github-actions

github-actionsBot commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actionsgithub-actionsBot added the SME stale The request for an SME has staled label Apr 21, 2022
@ethomson

ethomson commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

LGTM, thanks!

@ramyaparimiramyaparimi added SME reviewed An SME has reviewed this issue/PR and removed needs SME This proposal needs review from a subject matter expert SME stale The request for an SME has staled labels Apr 22, 2022
ramyaparimi
ramyaparimi approved these changes Apr 22, 2022
View reviewed changes

@ramyaparimiramyaparimi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chrico
Thanks so much for opening a PR with this fix! I'll get this merged once tests are passing 🍏

@ramyaparimi
ramyaparimi merged commit b5fe65b into github:mainApr 22, 2022
@github-actions

github-actionsBot commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@parrotyparroty mentioned this pull request Apr 29, 2022
Merged
5 tasks
docs-bot pushed a commit that referenced this pull request Feb 5, 2025
@am-stead
[Improvement]: Small security updates to core docs (1) - (Builders)#…
a4ab70a
…17059 (#54203)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Chrico
Chrico deleted the patch-2 branch May 19, 2025 07:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ramyaparimiramyaparimiramyaparimi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actionsThis issue or pull request should be reviewed by the docs actions teamcontentThis issue or pull request belongs to the Docs Content teamSME reviewedAn SME has reviewed this issue/PRwaiting for reviewIssue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Chrico@ethomson@ramyaparimi