Skip to content

Update "Configuring Git for GitHub Desktop" article - #18146

Merged
steveward merged 25 commits into
mainfrom
desktop-configuring-git
Jun 3, 2022
Merged

Update "Configuring Git for GitHub Desktop" article#18146
steveward merged 25 commits into
mainfrom
desktop-configuring-git

Conversation

@steveward

@stevewardsteveward commented May 23, 2022

Copy link
Copy Markdown
Member

Why:

Closes#4033

What's being changed:

  • Updated the "Configuring Git for GitHub Desktop" article with the new dropdown option for selecting an email address to use for committing
  • Added a section describing how to set an email address for commits on a per-repository basis
  • Updated a bunch of screenshots and created new ones where needed
  • Updated and renamed 'paste-email-git-config' to 'select-email-git-config' reusable since you can now use a dropdown to select an email address

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@stevewardsteveward added content This issue or pull request belongs to the Docs Content team desktop Content related to GitHub Desktop labels May 23, 2022
@github-actionsgithub-actionsBot added the triage Do not begin working on this issue until triaged by the team label May 23, 2022
@stevewardsteveward removed the triage Do not begin working on this issue until triaged by the team label May 23, 2022
@github-actions

github-actionsBot commented May 23, 2022

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

SourcePreviewProductionWhat Changed
desktop/contributing-and-collaborating-using-github-desktop/working-with-your-remote-repository-on-github-or-github-enterprise/changing-a-remotes-url-from-github-desktop.mdfpt
fpt
desktop/installing-and-configuring-github-desktop/configuring-and-customizing-github-desktop/configuring-git-for-github-desktop.mdfpt
fpt

@luxevwood

This comment was marked as spam.

@jkidd11jkidd11 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assets/images/help/desktop/mac-select-default-branch-name.png

@steveward
steveward marked this pull request as ready for review May 26, 2022 18:24
@steveward
steveward requested a review from lecoursenMay 26, 2022 18:41

@lecoursenlecoursen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great @steveward! ✨ In one of my comments I asked you to add another brief paragraph, and I'll give this another quick review after you do!

Comment threaddata/reusables/desktop/select-git-config.md Outdated
Comment threaddata/reusables/desktop/use-local-git-config.md Outdated
@steveward

Copy link
Copy Markdown
MemberAuthor

@lecoursen this should be ready for another review! Thanks!

lecoursen
lecoursen previously approved these changes Jun 2, 2022

@lecoursenlecoursen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so great @steveward! 🎉:sparkles: I left two small suggestions to consider, but this looks ready to merge after you 👀 those.

…sktop/working-with-your-remote-repository-on-github-or-github-enterprise/changing-a-remotes-url-from-github-desktop.md
Co-authored-by: Laura Coursen <lecoursen@github.com>
stevewardand others added 3 commits June 3, 2022 09:58
…iguring-and-customizing-github-desktop/configuring-git-for-github-desktop.md
Co-authored-by: Laura Coursen <lecoursen@github.com>
@steveward
steveward enabled auto-merge June 3, 2022 14:46
@steveward
steveward merged commit c1c5fda into mainJun 3, 2022
@steveward
steveward deleted the desktop-configuring-git branch June 3, 2022 14:58
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contentThis issue or pull request belongs to the Docs Content teamdesktopContent related to GitHub Desktop

Projects

None yet

Development

Successfully merging this pull request may close these issues.

https://github.com/aws/aws-sdk-ruby/commit/3665106e009d2e46b022b00997c939b1c28fb022 [GitHub Desktop] Update Configuring Git for GitHub Desktop Flow

4 participants

@steveward@luxevwood@lecoursen@jkidd11