Skip to content

Added correct commands for steps on Creating a Docker container action page - #20132

Merged
jc-clark merged 11 commits into
github:mainfrom
noviicee:noviicee
Sep 28, 2022
Merged

Added correct commands for steps on Creating a Docker container action page#20132
jc-clark merged 11 commits into
github:mainfrom
noviicee:noviicee

Conversation

@noviicee

@noviiceenoviicee commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

Why:

Closes#9432

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

changed to-

image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome

welcomeBot commented Aug 24, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actionsgithub-actionsBot added the triage Do not begin working on this issue until triaged by the team label Aug 24, 2022
@github-actions

github-actionsBot commented Aug 24, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

SourcePreviewProductionWhat Changed
actions/creating-actions/creating-a-docker-container-action.mdfpt
ghec
ghes@ 3.63.53.43.33.2
ghae
fpt
ghec
ghes@ 3.63.53.43.33.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@noviicee

noviicee commented Aug 25, 2022

Copy link
Copy Markdown
ContributorAuthor

@cmwilson21 can you have a look..? 😄

@cmwilson21

cmwilson21 commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

@noviicee Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 25, 2022
@noviicee

noviicee commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Hi! Any update..?

@cmwilson21

cmwilson21 commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

@noviicee Thanks for checking in! This is on our board for review. A reviewer will have eyes on it soon 👀

We appreciate your patience as we are working through our backlog. 💛

@noviicee

noviicee commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

@noviicee Thanks for checking in! This is on our board for review. A reviewer will have eyes on it soon eyes

We appreciate your patience as we are working through our backlog. yellow_heart

Sure! Thanks 💛 😄

jc-clark
jc-clark reviewed Sep 28, 2022
View reviewed changes
Comment threadcontent/actions/creating-actions/creating-a-docker-container-action.md Outdated
jc-clark
jc-clark previously approved these changes Sep 28, 2022
View reviewed changes

@jc-clarkjc-clark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing, @noviicee! ✨ I made some edits based on our content style guide. I'll commit these changes and merge the PR.

Comment threadcontent/actions/creating-actions/creating-a-docker-container-action.md Outdated
Comment threadcontent/actions/creating-actions/creating-a-docker-container-action.md Outdated
@jc-clarkjc-clark added the ready to merge This pull request is ready to merge label Sep 28, 2022
jc-clark
jc-clark reviewed Sep 28, 2022
View reviewed changes
Comment threadcontent/actions/creating-actions/creating-a-docker-container-action.md
@jc-clark
jc-clark merged commit 2fc4004 into github:mainSep 28, 2022
@github-actions

github-actionsBot commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@noviicee

noviicee commented Sep 29, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot @jc-clark ✨ ❤️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jc-clarkjc-clarkjc-clark approved these changes

Assignees

No one assigned

Labels

actionsThis issue or pull request should be reviewed by the docs actions teamcontentThis issue or pull request belongs to the Docs Content teamready to mergeThis pull request is ready to mergewaiting for reviewIssue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add correct commands for steps on Creating a Docker container action page

4 participants

@noviicee@cmwilson21@jc-clark@docubot