Skip to content

Use English for event names - #224

Closed
toshimaru wants to merge 1 commit into
github:mainfrom
toshimaru:update-ja-trigger-workflows
Closed

Use English for event names#224
toshimaru wants to merge 1 commit into
github:mainfrom
toshimaru:update-ja-trigger-workflows

Conversation

@toshimaru

@toshimarutoshimaru commented Oct 8, 2020

Copy link
Copy Markdown

Why:

Translations for event names are not needed.
So, use English event names instead of Japanese.

What's being changed:

  • Translated headings
  • Translated webhook payload names
Before

image

Afterワークフローをトリガーするイベント_-_GitHub_Docs

Check off the following:

@welcome

welcomeBot commented Oct 8, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@toshimaru
toshimaru marked this pull request as ready for review October 8, 2020 00:45
@toshimaru
toshimaru requested a review from a team as a code ownerOctober 8, 2020 00:45
Translations for event names are not needed.
So, use English event names
@toshimaru
toshimaruforce-pushed the update-ja-trigger-workflows branch from 2334b34 to 5fd8a6bCompareOctober 8, 2020 00:51
@zeke

zeke commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Thanks for opening this pull request @toshimaru!

Unfortunately, we are not able to accept pull requests for translated content. Our translation process involves an integration with an external service at crowdin.com, where all translation activity happens. We hope to eventually open up the translation process to the open-source community, but we're not there yet. See https://github.com/github/docs/blob/main/CONTRIBUTING.md#earth_asia-translations for more details.

I have opened an issue in our internal localization tracking repo with a link to the changes you've proposed here, and we'll make sure our translators get this fixed soon.

Thanks again!

@zekezeke closed this Oct 8, 2020
@zekezeke added the localization Issue or PR relating to translation or localization label Oct 8, 2020
@toshimaru
toshimaru deleted the update-ja-trigger-workflows branch October 20, 2020 00:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localizationIssue or PR relating to translation or localization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@toshimaru@zeke