Skip to content

Add Octocrab to third party libraries - #2380

Merged
skedwards88 merged 2 commits into
github:mainfrom
XAMPPRocky:patch-1
Jan 19, 2021
Merged

Add Octocrab to third party libraries#2380
skedwards88 merged 2 commits into
github:mainfrom
XAMPPRocky:patch-1

Conversation

@XAMPPRocky

@XAMPPRockyXAMPPRocky commented Dec 27, 2020

Copy link
Copy Markdown
Contributor

Why:

Developers writing their GitHub integrations in Rust, might be interested in using the octocrab library.

What's being changed:

Adds the octocrab library to list of third party libraries.

Check off the following:

@welcome

welcomeBot commented Dec 27, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

janiceilene commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilenejaniceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 28, 2020
@github-actions

github-actionsBot commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added the stale There is no recent activity on this issue or pull request label Jan 4, 2021
@XAMPPRocky

XAMPPRocky commented Jan 5, 2021

Copy link
Copy Markdown
ContributorAuthor

I'm not sure how this would be stale on my end when it's pending review.

@github-actionsgithub-actionsBot removed the stale There is no recent activity on this issue or pull request label Jan 5, 2021
@janiceilene

janiceilene commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@XAMPPRocky

XAMPPRocky commented Jan 7, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@janiceilene I understand that, however it's pretty bad experience as a contributor to get a comment that a PR will be closed where's there's nothing I can do other than comment on it, it's unneeded noise for both contributors and the team. It would be nice if there was a label such as waiting on review that disabled the stale bot for PRs with that label while team works through their backlog.

@janiceilene

janiceilene commented Jan 8, 2021

Copy link
Copy Markdown
Contributor

I appreciate that perspective and that's a great suggestion! I'll bring that up with the team.

@github-actions

github-actionsBot commented Jan 16, 2021

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added the stale There is no recent activity on this issue or pull request label Jan 16, 2021
@XAMPPRocky

XAMPPRocky commented Jan 16, 2021

Copy link
Copy Markdown
ContributorAuthor

:)

@github-actionsgithub-actionsBot removed the stale There is no recent activity on this issue or pull request label Jan 17, 2021
@skedwards88skedwards88 self-assigned this Jan 19, 2021
skedwards88
skedwards88 approved these changes Jan 19, 2021
View reviewed changes

@skedwards88skedwards88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for making this addition! I'll get this merged down for you.

@skedwards88skedwards88 added the ready to merge This pull request is ready to merge label Jan 19, 2021
@skedwards88
skedwards88 merged commit 708fd5e into github:mainJan 19, 2021
@github-actions

github-actionsBot commented Jan 19, 2021

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

This was referenced Mar 17, 2023
Open
Open
This was referenced Apr 19, 2023
Open
Open
@snyk-botsnyk-bot mentioned this pull request Apr 27, 2023
Open
@snyk-botsnyk-bot mentioned this pull request May 10, 2023
Open
This was referenced May 31, 2023
Open
Open
@snyk-botsnyk-bot mentioned this pull request Jun 9, 2023
Open
@MhmonicoxMhmonicox mentioned this pull request Jun 27, 2023
Open
@nicholaschoi168nicholaschoi168 mentioned this pull request Jun 28, 2023
Open
@Mdbabul41Mdbabul41 mentioned this pull request Jun 28, 2023
Open
@MhmonicoxMhmonicox mentioned this pull request Jul 10, 2023
Open
@MiivaanMiivaan mentioned this pull request Jul 17, 2023
Open
@MancentMancent mentioned this pull request Jul 18, 2023
Open
@MhmonicoxMhmonicox mentioned this pull request Jul 18, 2023
Open
@MhmonicoxMhmonicox mentioned this pull request Aug 8, 2023
Open
@MhmonicoxMhmonicox mentioned this pull request Aug 21, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@skedwards88skedwards88skedwards88 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skedwards88skedwards88

Labels

contentThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem teamready to mergeThis pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XAMPPRocky@janiceilene@skedwards88