Skip to content

remove translations/*/content/README.md - #256

Merged
zeke merged 2 commits into
github:mainfrom
shogo82148:remove-translations-content-readme
Oct 8, 2020
Merged

remove translations/*/content/README.md#256
zeke merged 2 commits into
github:mainfrom
shogo82148:remove-translations-content-readme

Conversation

@shogo82148

Copy link
Copy Markdown
Contributor

Why:

Some translated documents have content/README.md (but not all).
These files are ignored by crowdin.yml, so they are never updated by the Crowdin integration.

"/content/README.md"

I think that these files were committed by mistake.
They confuse us because they keep holding on to old information.

What's being changed:

I removed them.

Check off the following:

@shogo82148
shogo82148 requested a review from a team as a code ownerOctober 8, 2020 09:33
@welcome

welcomeBot commented Oct 8, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@zekezeke added engineering Will involve Docs Engineering localization Issue or PR relating to translation or localization labels Oct 8, 2020
zeke
zeke approved these changes Oct 8, 2020

@zekezeke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @shogo82148. Those README files are supposed to by ignored by our Crowdin integration but it looks like they slipped through the cracks at some point.

I'll merge this when all checks are passing.

@zeke
zeke merged commit 6cebc9a into github:mainOct 8, 2020
@shogo82148
shogo82148 deleted the remove-translations-content-readme branch October 9, 2020 01:20
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* Fix link
* Add space
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineeringWill involve Docs EngineeringlocalizationIssue or PR relating to translation or localization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shogo82148@zeke